Re: [PATCH] bpf: Use tracing helpers for lsm programs

Song Liu
2020-06-01T22:52:37Z

On Mon, Jun 1, 2020 at 3:12 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Mon, Jun 1, 2020 at 12:00 PM Song Liu <song@kernel.org> wrote:
> >
> > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > >
> > > Currenty lsm uses bpf_tracing_func_proto helpers which do
> > > not include stack trace or perf event output. It's useful
> > > to have those for bpftrace lsm support [1].
> > >
> > > Using tracing_prog_func_proto helpers for lsm programs.
> >
> > How about using raw_tp_prog_func_proto?
>
> why?
> I think skb/xdp_output is useful for lsm progs too.
> So I've applied the patch.

The only reason I asked was that the commit log only said stack trace and
perf event output. No objections allowing other helpers for lsm.

Thanks,
Song