From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA13CC433E0 for ; Tue, 7 Jul 2020 15:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B8AB206E2 for ; Tue, 7 Jul 2020 15:35:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G0RyWbGv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729082AbgGGPfX (ORCPT ); Tue, 7 Jul 2020 11:35:23 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:40486 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728950AbgGGPfX (ORCPT ); Tue, 7 Jul 2020 11:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594136121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ivVNSMcbJF65hKWwG/H5LBC+U8oQzuS+tuEvFIY7aUY=; b=G0RyWbGvmE/VfVfuOtscdbUwj9Pid3JIAveVpq5HJ15BgUuV1IeLY6WTLXWyfjcLsZo3Nr vpUxGRTG7Y6QbWQkDk4GrWfjmaBzLAS7WBbR81dQcoNvvWM1JczqrNz+IDlZoan1OyHkwc JUX3oSUhi87lAp49lNkN3hB+cRZxq+o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-r9VFWpgsPyeB57z9Jd07rg-1; Tue, 07 Jul 2020 11:35:17 -0400 X-MC-Unique: r9VFWpgsPyeB57z9Jd07rg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02B9518FE887; Tue, 7 Jul 2020 15:35:07 +0000 (UTC) Received: from krava (unknown [10.40.195.209]) by smtp.corp.redhat.com (Postfix) with SMTP id DC12873FEA; Tue, 7 Jul 2020 15:35:02 +0000 (UTC) Date: Tue, 7 Jul 2020 17:35:01 +0200 From: Jiri Olsa To: Andrii Nakryiko Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , bpf , Song Liu , Yonghong Song , Martin KaFai Lau , David Miller , John Fastabend , Wenbo Zhang , KP Singh , Brendan Gregg , Florent Revest , Al Viro Subject: Re: [PATCH v5 bpf-next 4/9] bpf: Resolve BTF IDs in vmlinux image Message-ID: <20200707153501.GF3424581@krava> References: <20200703095111.3268961-1-jolsa@kernel.org> <20200703095111.3268961-5-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jul 06, 2020 at 05:38:54PM -0700, Andrii Nakryiko wrote: > On Fri, Jul 3, 2020 at 2:52 AM Jiri Olsa wrote: > > > > Using BTF_ID_LIST macro to define lists for several helpers > > using BTF arguments. > > > > And running resolve_btfids on vmlinux elf object during linking, > > so the .BTF_ids section gets the IDs resolved. > > > > Acked-by: Andrii Nakryiko > > Signed-off-by: Jiri Olsa > > --- > > Makefile | 3 ++- > > kernel/trace/bpf_trace.c | 9 +++++++-- > > net/core/filter.c | 9 +++++++-- > > scripts/link-vmlinux.sh | 6 ++++++ > > 4 files changed, 22 insertions(+), 5 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 8db4fd8097e0..def58d4f9ed7 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -448,6 +448,7 @@ OBJSIZE = $(CROSS_COMPILE)size > > STRIP = $(CROSS_COMPILE)strip > > endif > > PAHOLE = pahole > > +RESOLVE_BTFIDS = $(srctree)/tools/bpf/resolve_btfids/resolve_btfids > > Oh, this is probably wrong and why out-of-tree build fails. Why don't > you follow how this is done for objtool? right, should be $(objtree) in there jirka > > > LEX = flex > > YACC = bison > > AWK = awk > > @@ -510,7 +511,7 @@ GCC_PLUGINS_CFLAGS := > > CLANG_FLAGS := > > > > export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC > > -export CPP AR NM STRIP OBJCOPY OBJDUMP OBJSIZE READELF PAHOLE LEX YACC AWK INSTALLKERNEL > > +export CPP AR NM STRIP OBJCOPY OBJDUMP OBJSIZE READELF PAHOLE RESOLVE_BTFIDS LEX YACC AWK INSTALLKERNEL > > export PERL PYTHON PYTHON3 CHECK CHECKFLAGS MAKE UTS_MACHINE HOSTCXX > > export KGZIP KBZIP2 KLZOP LZMA LZ4 XZ > > export KBUILD_HOSTCXXFLAGS KBUILD_HOSTLDFLAGS KBUILD_HOSTLDLIBS LDFLAGS_MODULE > > [...] >