Re: [PATCH v5 bpf-next 5/9] bpf: Remove btf_id helpers resolving

Andrii Nakryiko
2020-07-07T00:46:26Z

On Fri, Jul 3, 2020 at 2:52 AM Jiri Olsa <jolsa@kernel.org> wrote:
>
> Now when we moved the helpers btf_id arrays into .BTF_ids section,
> we can remove the code that resolve those IDs in runtime.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> kernel/bpf/btf.c | 89 +++---------------------------------------------
> 1 file changed, 5 insertions(+), 84 deletions(-)
>

LGTM.

Acked-by: Andrii Nakryiko <andriin@fb.com>

> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 4c3007f428b1..71140b73ae3c 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -4079,96 +4079,17 @@ int btf_struct_access(struct bpf_verifier_log *log,
> return -EINVAL;
> }
> …