From: Balamuruhan S <bala24@linux.ibm.com>
To: bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
naveen.n.rao@linux.vnet.ibm.com, ravi.bangoria@linux.ibm.com,
sandipan@linux.ibm.com, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, andriin@fb.com, john.fastabend@gmail.com,
kpsingh@chromium.org, Balamuruhan S <bala24@linux.ibm.com>
Subject: [PATCH bpf] selftest/bpf: make bpftool if it is not already built
Date: Fri, 14 Aug 2020 14:27:56 +0530 [thread overview]
Message-ID: <20200814085756.205609-1-bala24@linux.ibm.com> (raw)
test_bpftool error out if bpftool is not available in bpftool dir
linux/tools/bpf/bpftool, build and clean it as part of test
bootstrap and teardown.
Error log:
---------
test_feature_dev_json (test_bpftool.TestBpftool) ... ERROR
test_feature_kernel (test_bpftool.TestBpftool) ... ERROR
test_feature_kernel_full (test_bpftool.TestBpftool) ... ERROR
test_feature_kernel_full_vs_not_full (test_bpftool.TestBpftool) ... ERROR
test_feature_macros (test_bpftool.TestBpftool) ... ERROR
======================================================================
ERROR: test_feature_dev_json (test_bpftool.TestBpftool)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/ubuntu/disk/linux/tools/testing/selftests/bpf/test_bpftool.py",
return f(*args, iface, **kwargs)
File "/home/ubuntu/disk/linux/tools/testing/selftests/bpf/test_bpftool.py",
res = bpftool_json(["feature", "probe", "dev", iface])
File "/home/ubuntu/disk/linux/tools/testing/selftests/bpf/test_bpftool.py",
res = _bpftool(args)
File "/home/ubuntu/disk/linux/tools/testing/selftests/bpf/test_bpftool.py",
return subprocess.check_output(_args)
File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 489, in run
with Popen(*popenargs, **kwargs) as process:
File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'bpftool'
Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
---
tools/testing/selftests/bpf/test_bpftool.py | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_bpftool.py b/tools/testing/selftests/bpf/test_bpftool.py
index 4fed2dc25c0a..60357c6891a6 100644
--- a/tools/testing/selftests/bpf/test_bpftool.py
+++ b/tools/testing/selftests/bpf/test_bpftool.py
@@ -58,12 +58,25 @@ def default_iface(f):
return wrapper
+def make_bpftool(clean=False):
+ cmd = "make"
+ if clean:
+ cmd = "make clean"
+ return subprocess.run(cmd, shell=True, cwd=bpftool_dir, check=True,
+ stdout=subprocess.DEVNULL)
+
class TestBpftool(unittest.TestCase):
@classmethod
def setUpClass(cls):
if os.getuid() != 0:
raise UnprivilegedUserError(
"This test suite needs root privileges")
+ if subprocess.getstatusoutput("bpftool -h")[0]:
+ make_bpftool()
+
+ @classmethod
+ def tearDownClass(cls):
+ make_bpftool(clean=True)
@default_iface
def test_feature_dev_json(self, iface):
base-commit: 6e868cf355725fbe9fa512d01b09b8ee7f3358f0
--
2.24.1
next reply other threads:[~2020-08-14 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:57 Balamuruhan S [this message]
2020-08-14 16:01 ` [PATCH bpf] selftest/bpf: make bpftool if it is not already built Yonghong Song
2020-08-18 7:44 ` Balamuruhan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814085756.205609-1-bala24@linux.ibm.com \
--to=bala24@linux.ibm.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sandipan@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox