From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>, bpf@vger.kernel.org
Cc: Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
ykaliuta@redhat.com, zsun@redhat.com, vkabatov@redhat.com
Subject: Re: [PATCH bpf] selftests/bpf: Fix massive output from test_maps
Date: Wed, 26 Aug 2020 10:29:30 +0200 [thread overview]
Message-ID: <20200826102930.51486b11@carbon> (raw)
In-Reply-To: <159842985651.1050885.2154399297503372406.stgit@firesoul>
On Wed, 26 Aug 2020 10:17:36 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> When stdout output from the selftests tool 'test_maps' gets redirected
> into e.g file or pipe, then the output lines increase a lot (from 21
> to 33949 lines). This is caused by the printf that happens before the
> fork() call, and there are user-space buffered printf data that seems
> to be duplicated into the forked process.
>
> To fix this fflush() stdout before the fork loop in __run_parallel().
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Fixes: 1a97cf1fe503 ("selftests/bpf: speedup test_maps")
I forgot to add the fixes line to the patch, I hope patchwork[1] will
pick it up for maintainers.
[1] http://patchwork.ozlabs.org/project/netdev/patch/159842985651.1050885.2154399297503372406.stgit@firesoul/
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-08-26 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 8:17 [PATCH bpf] selftests/bpf: Fix massive output from test_maps Jesper Dangaard Brouer
2020-08-26 8:29 ` Jesper Dangaard Brouer [this message]
2020-08-28 12:00 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826102930.51486b11@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=vkabatov@redhat.com \
--cc=ykaliuta@redhat.com \
--cc=zsun@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox