From: "Björn Töpel" <bjorn.topel@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
magnus.karlsson@intel.com, kuba@kernel.org,
intel-wired-lan@lists.osuosl.org
Subject: [PATCH bpf-next 1/4] xsk: add XSK_NAPI_WEIGHT define
Date: Mon, 7 Sep 2020 17:02:14 +0200 [thread overview]
Message-ID: <20200907150217.30888-2-bjorn.topel@gmail.com> (raw)
In-Reply-To: <20200907150217.30888-1-bjorn.topel@gmail.com>
From: Björn Töpel <bjorn.topel@intel.com>
The NAPI budget (NAPI_POLL_WEIGHT), meaning the number of received
packets that are allowed to be processed for each NAPI invocation,
takes into consideration that each received packet is aimed for the
kernel networking stack.
That is not the case for the AF_XDP receive path, where the cost of
each packet is significantly less. Therefore, this commit adds a new
NAPI budget, which is the NAPI_POLL_WEIGHT scaled by 4. Typically that
would be 256 in most configuration. It is encouraged that AF_XDP
zero-copy capable drivers use the XSK_NAPI_WEIGHT, when zero-copy is
enabled.
Processing 256 packets targeted for AF_XDP is still less work than 64
(NAPI_POLL_WEIGHT) packets going to the kernel networking stack.
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
include/net/xdp_sock_drv.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
index 5b1ee8a9976d..4fc8e931d56f 100644
--- a/include/net/xdp_sock_drv.h
+++ b/include/net/xdp_sock_drv.h
@@ -7,8 +7,11 @@
#define _LINUX_XDP_SOCK_DRV_H
#include <net/xdp_sock.h>
+#include <linux/netdevice.h>
#include <net/xsk_buff_pool.h>
+#define XSK_NAPI_WEIGHT (NAPI_POLL_WEIGHT << 2)
+
#ifdef CONFIG_XDP_SOCKETS
void xsk_tx_completed(struct xsk_buff_pool *pool, u32 nb_entries);
--
2.25.1
next prev parent reply other threads:[~2020-09-07 15:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 15:02 [PATCH bpf-next 0/4] xsk: increase NAPI budget for AF_XDP zero-copy path Björn Töpel
2020-09-07 15:02 ` Björn Töpel [this message]
2020-09-07 15:02 ` [PATCH bpf-next 2/4] i40e, xsk: use XSK_NAPI_WEIGHT as NAPI poll budget Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 3/4] ice, " Björn Töpel
2020-09-07 15:02 ` [PATCH bpf-next 4/4] ixgbe, " Björn Töpel
2020-09-07 19:32 ` Jakub Kicinski
2020-09-08 5:38 ` Björn Töpel
2020-09-08 9:45 ` Eric Dumazet
2020-09-08 11:49 ` Björn Töpel
2020-09-08 15:12 ` Eric Dumazet
2020-09-08 10:12 ` [Intel-wired-lan] " Paul Menzel
2020-09-08 11:12 ` Björn Töpel
2020-09-08 11:20 ` Paul Menzel
2020-09-08 11:43 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907150217.30888-2-bjorn.topel@gmail.com \
--to=bjorn.topel@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox