Re: [PATCH 3/3] btf_encoder: Include static functions to BTF data

[Jiri Olsa <jolsa@redhat.com>]

On Tue, Oct 27, 2020 at 04:21:14PM -0700, Andrii Nakryiko wrote:
> On Mon, Oct 26, 2020 at 5:07 PM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > Removing the condition to skip static functions.
> >
> > Getting extra 23k functions on my kernel .config:
> >
> >            nr     .BTF size (bytes)
> >   before:  23291  3342279
> >    after:  46606  4361045
> 
> almost exactly 2x... such coincidences make me nervous ;)

hum, nice.. 'new' functions looked good, I'll make the
full list to be sure

jirka

> 
> >
> > The BTF section size increased of about 1MB.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  btf_encoder.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/btf_encoder.c b/btf_encoder.c
> > index 99b9abe36993..03a4bef11947 100644
> > --- a/btf_encoder.c
> > +++ b/btf_encoder.c
> > @@ -485,9 +485,6 @@ int cu__encode_btf(struct cu *cu, int verbose, bool force,
> >                 int btf_fnproto_id, btf_fn_id;
> >                 const char *name;
> >
> > -               if (!fn->external)
> > -                       continue;
> > -
> >                 /*
> >                  * We need to generate just single BTF instance for the
> >                  * function, while DWARF data contains multiple instances
> > --
> > 2.26.2
> >
>