From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F7FC388F2 for ; Tue, 3 Nov 2020 05:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 061DE2227F for ; Tue, 3 Nov 2020 05:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GPb/l063" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726115AbgKCFyg (ORCPT ); Tue, 3 Nov 2020 00:54:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20315 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgKCFyf (ORCPT ); Tue, 3 Nov 2020 00:54:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604382874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2fl5tjNFV3PW85DHxc10S9tbrJNnWhGh5jiU6vVkExg=; b=GPb/l063k4FjxDoqemPrdmqX78Kf48iesdlj3sS9DSwXwaq8cSqgHzNnnuXmiNyzVzfab0 40BsQuIWJedGi5f5UpIHe10w8In8eHcGRP+AS3wo+ev6+PUPhZ1nrIRAEVsaOrL7XvjZ9A eRR6m+4UXLi0qCyBiW1ROuA4uET+08Q= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-9_7Q3jYRM8iINLKFJP2fkw-1; Tue, 03 Nov 2020 00:54:32 -0500 X-MC-Unique: 9_7Q3jYRM8iINLKFJP2fkw-1 Received: by mail-pf1-f200.google.com with SMTP id z22so5584320pfj.15 for ; Mon, 02 Nov 2020 21:54:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2fl5tjNFV3PW85DHxc10S9tbrJNnWhGh5jiU6vVkExg=; b=QY0gIpELsSHXOyPkxzu5I0njJTqtnitGuD3Hv5aE1f0XN5DQUnqkF8tfWStH6sl0EV JUD//P9xiRuzZb5hqjCX8scOvcNEWT8PF0Rwxaq36sdJA9ieAJdR5twuXeL2EOZdnvtO inADKWSo1PWtFKROIhQtba/C8YDI+zT9eBI6kfCSgTV9T0ufQ1kvLM6J+ITW0V1XZITC DOPgCJE9U7HWnGS48eJJf9a4HKSivaJGG8tUbCaWL1cmysboJkZbpJj3VhMnF3k1Qmrm Mu0PpdbZBkHtDrgF0iF/EM8WxUHqx9Wh1L0iTwdduY2QRyhP4V9j8aSI0JvtvJl0zgLX 2BZg== X-Gm-Message-State: AOAM530OS1Qes/TA5cPIkdyGJQR4ob3d+OnTC6tbLthdIf9JhbtsHU0b 0YpnvYPBI0Op0tOn/Wj/M4AurF00flfqC5lE4i0Hlv6gTCJsZXNka8uHo5KizblxxRBMmFXgl1L 7nOg94Yfu8VE= X-Received: by 2002:a63:6c09:: with SMTP id h9mr15569139pgc.214.1604382871468; Mon, 02 Nov 2020 21:54:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3t6HhBjRzKu/CyOzq+iHNPZNWP9i1v2iHNlC1M+VhSqvFWOW3I74UVfYwkU0MAgpW/+jVWw== X-Received: by 2002:a63:6c09:: with SMTP id h9mr15569117pgc.214.1604382871288; Mon, 02 Nov 2020 21:54:31 -0800 (PST) Received: from dhcp-12-153.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 136sm3905540pfb.152.2020.11.02.21.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 21:54:30 -0800 (PST) Date: Tue, 3 Nov 2020 13:54:19 +0800 From: Hangbin Liu To: David Ahern Cc: Stephen Hemminger , Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , David Miller , Jesper Dangaard Brouer , netdev@vger.kernel.org, bpf@vger.kernel.org, Jiri Benc , Andrii Nakryiko , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Subject: Re: [PATCHv3 iproute2-next 1/5] configure: add check_libbpf() for later libbpf support Message-ID: <20201103055419.GI2408@dhcp-12-153.nay.redhat.com> References: <20201028132529.3763875-1-haliu@redhat.com> <20201029151146.3810859-1-haliu@redhat.com> <20201029151146.3810859-2-haliu@redhat.com> <78c5df29-bf06-0b60-d914-bdab3d65b198@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78c5df29-bf06-0b60-d914-bdab3d65b198@gmail.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 02, 2020 at 08:37:37AM -0700, David Ahern wrote: > On 10/29/20 9:11 AM, Hangbin Liu wrote: > > This patch adds a check to see if we support libbpf. By default the > > system libbpf will be used, but static linking against a custom libbpf > > version can be achieved by passing LIBBPF_DIR to configure. FORCE_LIBBPF > > can be set to force configure to abort if no suitable libbpf is found, > > which is useful for automatic packaging that wants to enforce the > > dependency. > > > > Add an option to force libbpf off and use of the legacy code. i.e, yes > it is installed, but don't use it. > > configure script really needs a usage to dump options like disabling libbpf. > Shouldn't we use libbpf by default if system support? The same like libmnl. There is no options to force libnml off. Thanks Hangbin