From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Prankur gupta <prankgup@fb.com>
Cc: bpf@vger.kernel.org, kernel-team@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] bpf: Adds support for setting window clamp
Date: Tue, 1 Dec 2020 18:14:37 -0800 [thread overview]
Message-ID: <20201202021437.rbllajmj27u2ezyf@ast-mbp> (raw)
In-Reply-To: <20201201164357.2623610-2-prankgup@fb.com>
On Tue, Dec 01, 2020 at 08:43:56AM -0800, Prankur gupta wrote:
> Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_WINDOW_CLAMP,
> which sets the maximum receiver window size. It will be useful for
> limiting receiver window based on RTT.
>
> Signed-off-by: Prankur gupta <prankgup@fb.com>
> ---
> net/core/filter.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 2ca5eecebacf..8c52ffae7b0c 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -4910,6 +4910,19 @@ static int _bpf_setsockopt(struct sock *sk, int level, int optname,
> tp->notsent_lowat = val;
> sk->sk_write_space(sk);
> break;
> + case TCP_WINDOW_CLAMP:
> + if (!val) {
> + if (sk->sk_state != TCP_CLOSE) {
> + ret = -EINVAL;
> + break;
> + }
> + tp->window_clamp = 0;
> + } else {
> + tp->window_clamp =
> + val < SOCK_MIN_RCVBUF / 2 ?
> + SOCK_MIN_RCVBUF / 2 : val;
> + }
May be extract this logic into a helper instead of copy-paste?
next prev parent reply other threads:[~2020-12-02 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 16:43 [PATCH v2 bpf-next 0/2] Add support to set window_clamp from bpf setsockops Prankur gupta
2020-12-01 16:43 ` [PATCH bpf-next 1/2] bpf: Adds support for setting window clamp Prankur gupta
2020-12-02 2:14 ` Alexei Starovoitov [this message]
2020-12-01 16:43 ` [PATCH bpf-next 2/2] selftests/bpf: Add Userspace tests for TCP_WINDOW_CLAMP Prankur gupta
-- strict thread matches above, loose matches on Subject: below --
2020-12-01 0:03 [PATCH bpf-next 0/2] Add support to set window_clamp from bpf setsockops Prankur gupta
2020-12-01 0:03 ` [PATCH bpf-next 1/2] bpf: Adds support for setting window clamp Prankur gupta
2020-12-01 1:34 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202021437.rbllajmj27u2ezyf@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=prankgup@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox