From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A60C4361B for ; Wed, 9 Dec 2020 18:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBE8F22ADC for ; Wed, 9 Dec 2020 18:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732723AbgLISGp (ORCPT ); Wed, 9 Dec 2020 13:06:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732757AbgLISGh (ORCPT ); Wed, 9 Dec 2020 13:06:37 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5013CC0613D6; Wed, 9 Dec 2020 10:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=12hoQABG9FckSJ5OF/hyVqUM6/uXu85LiNPYtk8cpMI=; b=KOFYpz3RqQPlHcHKG+ldL7fwiD EBZrIoPnC6678N22HWrStGRcaNFqMuAKDX+c7AXHDobF4zvNKem7Nc6+7tRp0ns0QxsbXkRt9gqni ZMcfHsgE0J2S3DqFYPzx86o4GWRpq2WCz8qXwTfEUgSC/aZ3deUsXyp5JBz34nLjRputdUuOcbkgz KrtZsou0i1VpJhhWcxDSqjpvii23UJ7pLGahIeV3dlvry3RtMN6q/72lpUhQoiC7iOt1cRHb961QP MrIvoK0eTuAF31bqurJWyQK7bNyBhuW9D9stCIYSytyX6YdJyw6KD2Trpo49InOPcQbCSH5BPTrRO ROt5xuIA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn3qa-0007ZP-5Q; Wed, 09 Dec 2020 18:05:52 +0000 Date: Wed, 9 Dec 2020 18:05:52 +0000 From: Christoph Hellwig To: Stanislaw Gruszka Cc: Matthew Wilcox , Alexei Starovoitov , Michal Kubecek , Justin Forbes , bpf , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Message-ID: <20201209180552.GA28692@infradead.org> References: <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> <20201209144628.GA3474@wp.pl> <20201209150826.GP7338@casper.infradead.org> <20201209155148.GA5552@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209155148.GA5552@wp.pl> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Dec 09, 2020 at 04:51:48PM +0100, Stanislaw Gruszka wrote: > On Wed, Dec 09, 2020 at 03:08:26PM +0000, Matthew Wilcox wrote: > > On Wed, Dec 09, 2020 at 03:46:28PM +0100, Stanislaw Gruszka wrote: > > > At this point of release cycle we should probably go with revert, > > > but I think the main problem is that BPF and ERROR_INJECTION use > > > function that is not intended to be used externally. For external users > > > add_to_page_cache_lru() and add_to_page_cache_locked() are exported > > > and I think those should be used (see the patch below). > > > > FWIW, I intend to do some consolidation/renaming in this area. I > > trust that will not be a problem? > > If it does not break anything, it will be not a problem ;-) > > It's possible that __add_to_page_cache_locked() can be a global symbol > with add_to_page_cache_lru() + add_to_page_cache_locked() being just > static/inline wrappers around it. So what happens to BTF if we change this area entirely? Your IDs sound like some kind of ABI to me, which is extremely scary.