From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, anthony.l.nguyen@intel.com,
bjorn.topel@intel.com, magnus.karlsson@intel.com
Subject: Re: [PATCH net-next 5/8] ice: move skb pointer from rx_buf to rx_ring
Date: Mon, 14 Dec 2020 16:07:40 +0100 [thread overview]
Message-ID: <20201214150740.GA15222@ranger.igk.intel.com> (raw)
In-Reply-To: <20201211202315.570b6605@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Dec 11, 2020 at 08:23:15PM -0800, Jakub Kicinski wrote:
> On Fri, 11 Dec 2020 17:49:53 +0100 Maciej Fijalkowski wrote:
> > @@ -864,14 +865,12 @@ ice_reuse_rx_page(struct ice_ring *rx_ring, struct ice_rx_buf *old_buf)
> > * for use by the CPU.
> > */
> > static struct ice_rx_buf *
> > -ice_get_rx_buf(struct ice_ring *rx_ring, struct sk_buff **skb,
> > - const unsigned int size)
> > +ice_get_rx_buf(struct ice_ring *rx_ring, const unsigned int size)
> > {
>
> FWIW I think you missed adjusting kdoc here.
How ironic :) sorry for that.
next prev parent reply other threads:[~2020-12-14 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:49 [PATCH net-next 0/8] i40e/ice cleanups Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 1/8] i40e: drop redundant check when setting xdp prog Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 2/8] i40e: drop misleading function comments Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 3/8] i40e: adjust i40e_is_non_eop Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 4/8] ice: simplify ice_run_xdp Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 5/8] ice: move skb pointer from rx_buf to rx_ring Maciej Fijalkowski
2020-12-12 4:23 ` Jakub Kicinski
2020-12-14 15:07 ` Maciej Fijalkowski [this message]
2020-12-11 16:49 ` [PATCH net-next 6/8] ice: remove redundant checks in ice_change_mtu Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 7/8] ice: skip NULL check against XDP prog in ZC path Maciej Fijalkowski
2020-12-11 16:49 ` [PATCH net-next 8/8] i40e, xsk: Simplify the do-while allocation loop Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214150740.GA15222@ranger.igk.intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).