From: Jiang Wang <jiang.wang@bytedance.com>
To: bpf@vger.kernel.org
Cc: cong.wang@bytedance.com, kpsingh@google.com,
Jiang Wang <jiang.wang@bytedance.com>
Subject: [PATCH] selftests/bpf: fix a compile error for BPF_F_BPRM_SECUREEXEC
Date: Thu, 24 Dec 2020 01:12:42 +0000 [thread overview]
Message-ID: <20201224011242.585967-1-jiang.wang@bytedance.com> (raw)
When CONFIG_BPF_LSM is not configured, running bpf selftesting will show
BPF_F_BPRM_SECUREEXEC undefined error for bprm_opts.c.
The problem is that bprm_opts.c includes vmliunx.h. The vmlinux.h is
generated by "bpftool btf dump file ./vmlinux format c". On the other
hand, BPF_F_BPRM_SECUREEXEC is defined in include/uapi/linux/bpf.h
and used only in bpf_lsm.c. When CONFIG_BPF_LSM is not set, bpf_lsm
will not be compiled, so vmlinux.h will not include definition of
BPF_F_BPRM_SECUREEXEC.
Ideally, we want to compile bpf selftest regardless of the configuration
setting, so change the include file from vmlinux.h to bpf.h.
Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
---
tools/testing/selftests/bpf/progs/bprm_opts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/progs/bprm_opts.c b/tools/testing/selftests/bpf/progs/bprm_opts.c
index 5bfef2887e70..418d9c6d4952 100644
--- a/tools/testing/selftests/bpf/progs/bprm_opts.c
+++ b/tools/testing/selftests/bpf/progs/bprm_opts.c
@@ -4,7 +4,7 @@
* Copyright 2020 Google LLC.
*/
-#include "vmlinux.h"
+#include <linux/bpf.h>
#include <errno.h>
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>
--
2.11.0
next reply other threads:[~2020-12-24 1:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 1:12 Jiang Wang [this message]
2020-12-28 18:37 ` [PATCH] selftests/bpf: fix a compile error for BPF_F_BPRM_SECUREEXEC Song Liu
2020-12-29 5:14 ` John Fastabend
2020-12-29 14:28 ` Daniel Borkmann
2020-12-29 18:39 ` [External] " Jiang Wang .
2020-12-28 18:41 ` Song Liu
2020-12-29 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224011242.585967-1-jiang.wang@bytedance.com \
--to=jiang.wang@bytedance.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=kpsingh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox