BPF List
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
	magnus.karlsson@intel.com, bjorn@kernel.org,
	weqaar.a.janjua@intel.com
Subject: Re: [PATCH bpf-next v2 4/4] selftests/bpf: introduce xsk statistics tests
Date: Tue, 23 Feb 2021 15:41:36 +0100	[thread overview]
Message-ID: <20210223144136.GB51139@ranger.igk.intel.com> (raw)
In-Reply-To: <20210223103507.10465-5-ciara.loftus@intel.com>

On Tue, Feb 23, 2021 at 10:35:07AM +0000, Ciara Loftus wrote:
> This commit introduces a range of tests to the xsk testsuite
> for validating xsk statistics.
> 
> A new test type called 'stats' is added. Within it there are
> four sub-tests. Each test configures a scenario which should
> trigger the given error statistic. The test passes if the statistic
> is successfully incremented.
> 
> The four statistics for which tests have been created are:
> 1. rx dropped
> Increase the UMEM frame headroom to a value which results in
> insufficient space in the rx buffer for both the packet and the headroom.
> 2. tx invalid
> Set the 'len' field of tx descriptors to an invalid value (umem frame
> size + 1).
> 3. rx ring full
> Reduce the size of the RX ring to a fraction of the fill ring size.
> 4. fill queue empty
> Do not populate the fill queue and then try to receive pkts.

Thanks for adding descriptions!

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  tools/testing/selftests/bpf/xdpxceiver.c | 137 ++++++++++++++++++++---
>  tools/testing/selftests/bpf/xdpxceiver.h |  13 +++
>  2 files changed, 136 insertions(+), 14 deletions(-)
> 

      reply	other threads:[~2021-02-23 14:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 10:35 [PATCH bpf-next v2 0/4] selftests/bpf: xsk improvements and new stats tests Ciara Loftus
2021-02-23 10:35 ` [PATCH bpf-next v2 1/4] selftest/bpf: make xsk tests less verbose Ciara Loftus
2021-02-23 10:35 ` [PATCH bpf-next v2 2/4] selftests/bpf: expose and rename debug argument Ciara Loftus
2021-02-23 14:39   ` Maciej Fijalkowski
2021-02-23 15:01     ` Loftus, Ciara
2021-02-23 10:35 ` [PATCH bpf-next v2 3/4] selftests/bpf: restructure xsk selftests Ciara Loftus
2021-02-23 10:35 ` [PATCH bpf-next v2 4/4] selftests/bpf: introduce xsk statistics tests Ciara Loftus
2021-02-23 14:41   ` Maciej Fijalkowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223144136.GB51139@ranger.igk.intel.com \
    --to=maciej.fijalkowski@intel.com \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=ciara.loftus@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=weqaar.a.janjua@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox