From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87362C433E0 for ; Sat, 13 Mar 2021 13:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5617764F0F for ; Sat, 13 Mar 2021 13:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbhCMNax (ORCPT ); Sat, 13 Mar 2021 08:30:53 -0500 Received: from mail-40136.protonmail.ch ([185.70.40.136]:17620 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233529AbhCMNaj (ORCPT ); Sat, 13 Mar 2021 08:30:39 -0500 Date: Sat, 13 Mar 2021 13:30:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1615642236; bh=6r1N5OSEeyM3HNy+jVrlMhPyXWgVSnlITt0tT5FGaWU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=CTgpkDnM5DFkOhsoutj5H+n+LLd0lnuqmRm9fsR3jKhJfiCVKfBcS0G5U3xihok23 PRk8Ygz0XEKq4fu+OZrbyVk8G8/di1dlGIdBUkYF2hbJN5SOjnkFgBGB6nOUsCuUgC 8Mr2IkI9xqrbSeISjIm93HXg6Oy3UVx39hWWPOdmYqwf2q1Zj1K384wYhIxRZVH4AX IOsMfRCmlVjWbkmD81MSQzDOZGGd1CtbilKOpRTvpGZk4KcjLL2gG/pPA/BZQbCmDL zJ+BNWXHd3qDYMPQ1Am1ybNWR0S3JXXgjy7wB5NICMMByVD6YDp75ioNHrHuI4FWy0 p9Uf3yMsS8JnA== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jonathan Lemon , Eric Dumazet , Willem de Bruijn , Kevin Hao , Pablo Neira Ayuso , Jakub Sitnicki , Marco Elver , Dexuan Cui , Vladimir Oltean , Ariel Levkovich , Wang Qing , Davide Caratti , Guillaume Nault , Eran Ben Elisha , Mauro Carvalho Chehab , Kirill Tkhai , Bartosz Golaszewski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Reply-To: Alexander Lobakin Subject: Re: [PATCH v2 net-next 0/6] skbuff: micro-optimize flow dissection Message-ID: <20210313132956.647745-1-alobakin@pm.me> In-Reply-To: <20210313113645.5949-1-alobakin@pm.me> References: <20210313113645.5949-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org From: Alexander Lobakin Date: Sat, 13 Mar 2021 11:37:03 +0000 > This little number makes all of the flow dissection functions take > raw input data pointer as const (1-5) and shuffles the branches in > __skb_header_pointer() according to their hit probability. > > The result is +20 Mbps per flow/core with one Flow Dissector pass > per packet. This affects RPS (with software hashing), drivers that > use eth_get_headlen() on their Rx path and so on. > > Since v1 [0]: > - rebase on top of the latest net-next. This was super-weird, but > I double-checked that the series applies with no conflicts, and > then on Patchwork it didn't; Still failing on Patchwork. I rebased it ten thousand times, rebuilt the patches manually, tried previous stable Git version and the latest CVS snapshot, and always got the same series that successfully applies to next-next. Can you please take a look? > - no other changes. > > [0] https://lore.kernel.org/netdev/20210312194538.337504-1-alobakin@pm.me > > Alexander Lobakin (6): > flow_dissector: constify bpf_flow_dissector's data pointers > skbuff: make __skb_header_pointer()'s data argument const > flow_dissector: constify raw input @data argument > linux/etherdevice.h: misc trailing whitespace cleanup > ethernet: constify eth_get_headlen()'s @data argument > skbuff: micro-optimize {,__}skb_header_pointer() > > include/linux/etherdevice.h | 4 ++-- > include/linux/skbuff.h | 26 +++++++++++------------ > include/net/flow_dissector.h | 6 +++--- > net/core/flow_dissector.c | 41 +++++++++++++++++++----------------- > net/ethernet/eth.c | 2 +- > 5 files changed, 40 insertions(+), 39 deletions(-) > > -- > 2.30.2 Thanks, Al