BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
	Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	<kernel-team@fb.com>, Nick Desaulniers <ndesaulniers@google.com>,
	Sedat Dilek <sedat.dilek@gmail.com>
Subject: [PATCH bpf-next v2 1/5] selftests: set CC to clang in lib.mk if LLVM is set
Date: Mon, 12 Apr 2021 07:29:10 -0700	[thread overview]
Message-ID: <20210412142910.267222-1-yhs@fb.com> (raw)
In-Reply-To: <20210412142905.266942-1-yhs@fb.com>

selftests/bpf/Makefile includes lib.mk. With the following command
  make -j60 LLVM=1 LLVM_IAS=1  <=== compile kernel
  make -j60 -C tools/testing/selftests/bpf LLVM=1 LLVM_IAS=1 V=1
some files are still compiled with gcc. This patch
fixed lib.mk issue which sets CC to gcc in all cases.

Cc: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Yonghong Song <yhs@fb.com>
---
 tools/testing/selftests/lib.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index a5ce26d548e4..9a41d8bb9ff1 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -1,6 +1,10 @@
 # This mimics the top-level Makefile. We do it explicitly here so that this
 # Makefile can operate with or without the kbuild infrastructure.
+ifneq ($(LLVM),)
+CC := clang
+else
 CC := $(CROSS_COMPILE)gcc
+endif
 
 ifeq (0,$(MAKELEVEL))
     ifeq ($(OUTPUT),)
-- 
2.30.2


  reply	other threads:[~2021-04-12 14:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 14:29 [PATCH bpf-next v2 0/5] bpf: tools: support build selftests/bpf with clang Yonghong Song
2021-04-12 14:29 ` Yonghong Song [this message]
2021-04-12 14:29 ` [PATCH bpf-next v2 2/5] tools: allow proper CC/CXX/... override with LLVM=1 in Makefile.include Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 3/5] selftests/bpf: fix test_cpp compilation failure with clang Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 4/5] selftests/bpf: silence clang compilation warnings Yonghong Song
2021-04-13  4:45   ` Andrii Nakryiko
2021-04-12 14:29 ` [PATCH bpf-next v2 5/5] bpftool: fix a clang compilation warning Yonghong Song
2021-04-13  4:48   ` Andrii Nakryiko
2021-04-12 23:58 ` [PATCH bpf-next v2 0/5] bpf: tools: support build selftests/bpf with clang Nick Desaulniers
2021-04-13  0:02   ` Nick Desaulniers
2021-04-13  0:31     ` Yonghong Song
2021-04-13 18:46       ` Nick Desaulniers
2021-04-13 18:56         ` Nick Desaulniers
2021-04-13 20:35           ` Jiri Olsa
2021-04-13 20:45             ` Nick Desaulniers
2021-04-14 13:18               ` Jiri Olsa
2021-04-15  0:16                 ` Andrii Nakryiko
2021-04-15 13:23                   ` Jiri Olsa
2021-04-15 16:55                     ` Nick Desaulniers
2021-04-15 17:17                       ` Jiri Olsa
2021-04-15 21:39                         ` Jiri Olsa
2021-04-13  0:25   ` Yonghong Song
2021-04-13  1:44 ` Sedat Dilek
2021-04-13 15:21   ` Yonghong Song
2021-04-13  1:50 ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412142910.267222-1-yhs@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=ndesaulniers@google.com \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox