From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Wang Hai <wanghai38@huawei.com>
Cc: brouer@redhat.com, <davem@davemloft.net>, <kuba@kernel.org>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <andrii@kernel.org>, <kafai@fb.com>,
<songliubraving@fb.com>, <yhs@fb.com>, <kpsingh@kernel.org>,
<bpf@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage
Date: Wed, 16 Jun 2021 12:55:50 +0200 [thread overview]
Message-ID: <20210616125550.2f0e2544@carbon> (raw)
In-Reply-To: <20210615135724.29528-1-wanghai38@huawei.com>
On Tue, 15 Jun 2021 21:57:24 +0800
Wang Hai <wanghai38@huawei.com> wrote:
> xdp_sample_pkts usage() is missing the introduction of the
> "-S" option, this patch adds it.
>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> samples/bpf/xdp_sample_pkts_user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
> index 706475e004cb..495e09897bd3 100644
> --- a/samples/bpf/xdp_sample_pkts_user.c
> +++ b/samples/bpf/xdp_sample_pkts_user.c
> @@ -103,7 +103,8 @@ static void usage(const char *prog)
> fprintf(stderr,
> "%s: %s [OPTS] <ifname|ifindex>\n\n"
> "OPTS:\n"
> - " -F force loading prog\n",
> + " -F force loading prog\n"
> + " -S use skb-mode\n",
> __func__, prog);
> }
>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2021-06-16 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:57 [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage Wang Hai
2021-06-16 10:55 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616125550.2f0e2544@carbon \
--to=brouer@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=wanghai38@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox