From: Yucong Sun <fallentree@fb.com>
To: <andrii@kernel.org>
Cc: <bpf@vger.kernel.org>, Yucong Sun <sunyucong@gmail.com>
Subject: [PATCH v5 bpf-next 2/3] selftests/bpf: add per worker cgroup suffix
Date: Wed, 15 Sep 2021 20:26:40 -0700 [thread overview]
Message-ID: <20210916032641.1413293-3-fallentree@fb.com> (raw)
In-Reply-To: <20210916032641.1413293-1-fallentree@fb.com>
From: Yucong Sun <sunyucong@gmail.com>
This patch allows each worker to use a unique cgroup base directory, thus
allowing tests that uses cgroups to run concurrently.
Signed-off-by: Yucong Sun <sunyucong@gmail.com>
---
tools/testing/selftests/bpf/cgroup_helpers.c | 5 +++--
tools/testing/selftests/bpf/cgroup_helpers.h | 1 +
tools/testing/selftests/bpf/test_progs.c | 5 +++++
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 033051717ba5..a0429f0d6db2 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -29,9 +29,10 @@
#define WALK_FD_LIMIT 16
#define CGROUP_MOUNT_PATH "/mnt"
#define CGROUP_WORK_DIR "/cgroup-test-work-dir"
+const char *CGROUP_WORK_DIR_SUFFIX = "";
#define format_cgroup_path(buf, path) \
- snprintf(buf, sizeof(buf), "%s%s%s", CGROUP_MOUNT_PATH, \
- CGROUP_WORK_DIR, path)
+ snprintf(buf, sizeof(buf), "%s%s%s%s", CGROUP_MOUNT_PATH, \
+ CGROUP_WORK_DIR, CGROUP_WORK_DIR_SUFFIX, path)
/**
* enable_all_controllers() - Enable all available cgroup v2 controllers
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.h b/tools/testing/selftests/bpf/cgroup_helpers.h
index 5fe3d88e4f0d..5657aba02161 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.h
+++ b/tools/testing/selftests/bpf/cgroup_helpers.h
@@ -16,4 +16,5 @@ int setup_cgroup_environment(void);
void cleanup_cgroup_environment(void);
unsigned long long get_cgroup_id(const char *path);
+extern const char *CGROUP_WORK_DIR_SUFFIX;
#endif
diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
index 36f130455b2f..77ed9204cc4a 100644
--- a/tools/testing/selftests/bpf/test_progs.c
+++ b/tools/testing/selftests/bpf/test_progs.c
@@ -1157,6 +1157,11 @@ static int server_main(void)
static int worker_main(int sock)
{
+ static char suffix[16];
+
+ sprintf(suffix, "%d", env.worker_id);
+ CGROUP_WORK_DIR_SUFFIX = suffix;
+
save_netns();
while (true) {
--
2.30.2
next prev parent reply other threads:[~2021-09-16 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 3:26 [PATCH v5 bpf-next 0/3] selftests/bpf: Add parallelism to test_progs Yucong Sun
2021-09-16 3:26 ` [PATCH v5 bpf-next 1/3] " Yucong Sun
2021-09-17 18:43 ` Andrii Nakryiko
2021-09-17 18:54 ` Andrii Nakryiko
2021-09-17 19:44 ` Andrii Nakryiko
2021-09-16 3:26 ` Yucong Sun [this message]
2021-09-17 21:10 ` [PATCH v5 bpf-next 2/3] selftests/bpf: add per worker cgroup suffix Andrii Nakryiko
2021-09-16 3:26 ` [PATCH v5 bpf-next 3/3] selftests/bpf: pin some tests to worker 0 Yucong Sun
2021-09-17 21:22 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916032641.1413293-3-fallentree@fb.com \
--to=fallentree@fb.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sunyucong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox