From: Hengqi Chen <hengqi.chen@gmail.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
yhs@fb.com, john.fastabend@gmail.com, hengqi.chen@gmail.com
Subject: [PATCH bpf-next 0/2] libbpf: Support uniform BTF-defined key/value specification across all BPF maps
Date: Fri, 1 Oct 2021 00:14:54 +0800 [thread overview]
Message-ID: <20210930161456.3444544-1-hengqi.chen@gmail.com> (raw)
Currently a bunch of (usually pretty specialized) BPF maps do not support
specifying BTF types for they key and value. For such maps, specifying
their definition like this:
struct {
__uint(type, BPF_MAP_TYPE_PERF_EVENT_ARRAY);
__type(key, int);
__type(value, int);
} my_perf_buf SEC(".maps");
Would actually produce warnings about retrying BPF map creation without BTF.
Users are forced to know such nuances and use __uint(key_size, 4) instead.
This is non-uniform, annoying, and inconvenient.
This patch set teaches libbpf to recognize those specialized maps and removes
BTF type IDs when creating BPF map. Also, update existing BPF selftests to
exericse this change.
Hengqi Chen (2):
libbpf: Support uniform BTF-defined key/value specification across all
BPF maps
selftests/bpf: Use BTF-defined key/value for map definitions
tools/lib/bpf/libbpf.c | 24 +++++++++++++++++++
tools/testing/selftests/bpf/progs/kfree_skb.c | 4 ++--
.../selftests/bpf/progs/perf_event_stackmap.c | 4 ++--
.../bpf/progs/sockmap_verdict_prog.c | 12 +++++-----
.../selftests/bpf/progs/test_btf_map_in_map.c | 14 +++++------
.../selftests/bpf/progs/test_map_in_map.c | 10 ++++----
.../bpf/progs/test_map_in_map_invalid.c | 2 +-
.../bpf/progs/test_pe_preserve_elems.c | 8 +++----
.../selftests/bpf/progs/test_perf_buffer.c | 4 ++--
.../bpf/progs/test_select_reuseport_kern.c | 4 ++--
.../bpf/progs/test_stacktrace_build_id.c | 4 ++--
.../selftests/bpf/progs/test_stacktrace_map.c | 4 ++--
.../selftests/bpf/progs/test_tcpnotify_kern.c | 4 ++--
.../selftests/bpf/progs/test_xdp_bpf2bpf.c | 4 ++--
14 files changed, 62 insertions(+), 40 deletions(-)
--
2.30.2
next reply other threads:[~2021-09-30 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 16:14 Hengqi Chen [this message]
2021-09-30 16:14 ` [PATCH bpf-next 1/2] libbpf: Support uniform BTF-defined key/value specification across all BPF maps Hengqi Chen
2021-09-30 16:14 ` [PATCH bpf-next 2/2] selftests/bpf: Use BTF-defined key/value for map definitions Hengqi Chen
2021-10-01 22:35 ` [PATCH bpf-next 0/2] libbpf: Support uniform BTF-defined key/value specification across all BPF maps Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930161456.3444544-1-hengqi.chen@gmail.com \
--to=hengqi.chen@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox