Re: [PATCH bpf] bpf: Make CONFIG_DEBUG_INFO_BTF depend upon CONFIG_BPF_SYSCALL

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4577 bytes --]

Hi Kumar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf/master]

url:    https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/bpf-Make-CONFIG_DEBUG_INFO_BTF-depend-upon-CONFIG_BPF_SYSCALL/20211112-100114
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/ea181ce7046ae7f916b4ede6b04c48416d89b0b2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/bpf-Make-CONFIG_DEBUG_INFO_BTF-depend-upon-CONFIG_BPF_SYSCALL/20211112-100114
        git checkout ea181ce7046ae7f916b4ede6b04c48416d89b0b2
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/bpf/btf.c: In function 'btf_seq_show':
   kernel/bpf/btf.c:5876:22: warning: function 'btf_seq_show' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    5876 |  seq_vprintf((struct seq_file *)show->target, fmt, args);
         |                      ^~~~~~~~
   kernel/bpf/btf.c: In function 'btf_snprintf_show':
   kernel/bpf/btf.c:5913:2: warning: function 'btf_snprintf_show' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    5913 |  len = vsnprintf(show->target, ssnprintf->len_left, fmt, args);
         |  ^~~
   kernel/bpf/btf.c: At top level:
   kernel/bpf/btf.c:6349:8: error: redefinition of 'struct kfunc_btf_id_list'
    6349 | struct kfunc_btf_id_list {
         |        ^~~~~~~~~~~~~~~~~
   In file included from include/linux/bpf_verifier.h:8,
                    from kernel/bpf/btf.c:19:
   include/linux/btf.h:275:8: note: originally defined here
     275 | struct kfunc_btf_id_list {};
         |        ^~~~~~~~~~~~~~~~~
>> kernel/bpf/btf.c:6399:26: error: conflicting types for 'bpf_tcp_ca_kfunc_list'
    6399 | DEFINE_KFUNC_BTF_ID_LIST(bpf_tcp_ca_kfunc_list);
         |                          ^~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/btf.c:6395:27: note: in definition of macro 'DEFINE_KFUNC_BTF_ID_LIST'
    6395 |  struct kfunc_btf_id_list name = { LIST_HEAD_INIT(name.list),           \
         |                           ^~~~
   In file included from include/linux/bpf_verifier.h:8,
                    from kernel/bpf/btf.c:19:
   include/linux/btf.h:276:33: note: previous declaration of 'bpf_tcp_ca_kfunc_list' was here
     276 | static struct kfunc_btf_id_list bpf_tcp_ca_kfunc_list __maybe_unused;
         |                                 ^~~~~~~~~~~~~~~~~~~~~
>> kernel/bpf/btf.c:6400:26: error: conflicting types for 'prog_test_kfunc_list'
    6400 | DEFINE_KFUNC_BTF_ID_LIST(prog_test_kfunc_list);
         |                          ^~~~~~~~~~~~~~~~~~~~
   kernel/bpf/btf.c:6395:27: note: in definition of macro 'DEFINE_KFUNC_BTF_ID_LIST'
    6395 |  struct kfunc_btf_id_list name = { LIST_HEAD_INIT(name.list),           \
         |                           ^~~~
   In file included from include/linux/bpf_verifier.h:8,
                    from kernel/bpf/btf.c:19:
   include/linux/btf.h:277:33: note: previous declaration of 'prog_test_kfunc_list' was here
     277 | static struct kfunc_btf_id_list prog_test_kfunc_list __maybe_unused;
         |                                 ^~~~~~~~~~~~~~~~~~~~


vim +/bpf_tcp_ca_kfunc_list +6399 kernel/bpf/btf.c

14f267d95fe4b0 Kumar Kartikeya Dwivedi 2021-10-02  6393  
14f267d95fe4b0 Kumar Kartikeya Dwivedi 2021-10-02  6394  #define DEFINE_KFUNC_BTF_ID_LIST(name)                                         \
14f267d95fe4b0 Kumar Kartikeya Dwivedi 2021-10-02  6395  	struct kfunc_btf_id_list name = { LIST_HEAD_INIT(name.list),           \
14f267d95fe4b0 Kumar Kartikeya Dwivedi 2021-10-02  6396  					  __MUTEX_INITIALIZER(name.mutex) };   \
14f267d95fe4b0 Kumar Kartikeya Dwivedi 2021-10-02  6397  	EXPORT_SYMBOL_GPL(name)
0e32dfc80bae53 Kumar Kartikeya Dwivedi 2021-10-02  6398  
0e32dfc80bae53 Kumar Kartikeya Dwivedi 2021-10-02 @6399  DEFINE_KFUNC_BTF_ID_LIST(bpf_tcp_ca_kfunc_list);
c48e51c8b07aba Kumar Kartikeya Dwivedi 2021-10-02 @6400  DEFINE_KFUNC_BTF_ID_LIST(prog_test_kfunc_list);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34176 bytes --]