From: Masami Hiramatsu <mhiramat@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Martin KaFai Lau <kafai@fb.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [RFC 0/8] perf/bpf: Add batch support for [ku]probes attach
Date: Sun, 28 Nov 2021 19:34:50 +0900 [thread overview]
Message-ID: <20211128193450.8147832ab7d0d10494102ffb@kernel.org> (raw)
In-Reply-To: <20211124084119.260239-1-jolsa@kernel.org>
Hi Jiri,
On Wed, 24 Nov 2021 09:41:11 +0100
Jiri Olsa <jolsa@redhat.com> wrote:
> hi,
> adding support to create multiple kprobes/uprobes within single
> perf event. This way we can associate single bpf program with
> multiple kprobes.
Thanks for the change, basically, you can repeatedly call the
create_local_trace_kprobe() and register it.
>
> Sending this as RFC because I'm not completely sure I haven't
> missed anything in the trace/events area.
OK let me check that.
Thanks,
>
> Also it needs following uprobe fix to work properly:
> https://lore.kernel.org/lkml/20211123142801.182530-1-jolsa@kernel.org/
>
> Also available at:
> https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> bpf/kuprobe_batch
>
> thanks,
> jirka
>
>
> ---
> Jiri Olsa (8):
> perf/kprobe: Add support to create multiple probes
> perf/uprobe: Add support to create multiple probes
> libbpf: Add libbpf__kallsyms_parse function
> libbpf: Add struct perf_event_open_args
> libbpf: Add support to attach multiple [ku]probes
> libbpf: Add support for k[ret]probe.multi program section
> selftest/bpf: Add kprobe multi attach test
> selftest/bpf: Add uprobe multi attach test
>
> include/uapi/linux/perf_event.h | 1 +
> kernel/trace/trace_event_perf.c | 214 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------
> kernel/trace/trace_kprobe.c | 47 ++++++++++++++++---
> kernel/trace/trace_probe.c | 2 +-
> kernel/trace/trace_probe.h | 6 ++-
> kernel/trace/trace_uprobe.c | 43 +++++++++++++++--
> tools/include/uapi/linux/perf_event.h | 1 +
> tools/lib/bpf/libbpf.c | 235 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------
> tools/lib/bpf/libbpf.h | 25 +++++++++-
> tools/lib/bpf/libbpf_internal.h | 5 ++
> tools/testing/selftests/bpf/prog_tests/multi_kprobe_test.c | 83 +++++++++++++++++++++++++++++++++
> tools/testing/selftests/bpf/prog_tests/multi_uprobe_test.c | 97 ++++++++++++++++++++++++++++++++++++++
> tools/testing/selftests/bpf/progs/multi_kprobe.c | 58 +++++++++++++++++++++++
> tools/testing/selftests/bpf/progs/multi_uprobe.c | 26 +++++++++++
> 14 files changed, 765 insertions(+), 78 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/multi_kprobe_test.c
> create mode 100644 tools/testing/selftests/bpf/prog_tests/multi_uprobe_test.c
> create mode 100644 tools/testing/selftests/bpf/progs/multi_kprobe.c
> create mode 100644 tools/testing/selftests/bpf/progs/multi_uprobe.c
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2021-11-28 10:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:41 [RFC 0/8] perf/bpf: Add batch support for [ku]probes attach Jiri Olsa
2021-11-24 8:41 ` [PATCH 1/8] perf/kprobe: Add support to create multiple probes Jiri Olsa
2021-11-28 13:49 ` Masami Hiramatsu
2021-11-28 22:34 ` Jiri Olsa
2021-11-29 1:43 ` Masami Hiramatsu
2021-12-01 6:53 ` Andrii Nakryiko
2021-12-01 6:55 ` Andrii Nakryiko
2021-12-01 21:32 ` Jiri Olsa
2021-12-02 5:10 ` Alexei Starovoitov
2021-12-07 3:15 ` Andrii Nakryiko
2021-12-08 13:50 ` Jiri Olsa
2021-12-10 12:42 ` Jiri Olsa
2021-12-10 18:28 ` Andrii Nakryiko
2021-11-24 8:41 ` [PATCH 2/8] perf/uprobe: " Jiri Olsa
2021-11-24 8:41 ` [PATCH 3/8] libbpf: Add libbpf__kallsyms_parse function Jiri Olsa
2021-11-24 8:41 ` [PATCH 4/8] libbpf: Add struct perf_event_open_args Jiri Olsa
2021-11-24 8:41 ` [PATCH 5/8] libbpf: Add support to attach multiple [ku]probes Jiri Olsa
2021-11-24 8:41 ` [PATCH 6/8] libbpf: Add support for k[ret]probe.multi program section Jiri Olsa
2021-11-24 8:41 ` [PATCH 7/8] selftest/bpf: Add kprobe multi attach test Jiri Olsa
2021-11-24 8:41 ` [PATCH 8/8] selftest/bpf: Add uprobe " Jiri Olsa
2021-11-28 10:34 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211128193450.8147832ab7d0d10494102ffb@kernel.org \
--to=mhiramat@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox