From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
To: bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] bpf: return EOPNOTSUPP when JIT is needed and not possible
Date: Thu, 9 Dec 2021 10:40:38 -0300 [thread overview]
Message-ID: <20211209134038.41388-1-cascardo@canonical.com> (raw)
When a CBPF program is JITed and CONFIG_BPF_JIT_ALWAYS_ON is enabled, and
the JIT fails, it would return ENOTSUPP, which is not a valid userspace
error code. Instead, EOPNOTSUPP should be returned.
Fixes: 290af86629b2 ("bpf: introduce BPF_JIT_ALWAYS_ON config")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
kernel/bpf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index de3e5bc6781f..5c89bae0d6f9 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -1931,7 +1931,7 @@ struct bpf_prog *bpf_prog_select_runtime(struct bpf_prog *fp, int *err)
fp = bpf_int_jit_compile(fp);
bpf_prog_jit_attempt_done(fp);
if (!fp->jited && jit_needed) {
- *err = -ENOTSUPP;
+ *err = -EOPNOTSUPP;
return fp;
}
} else {
--
2.32.0
next reply other threads:[~2021-12-09 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:40 Thadeu Lima de Souza Cascardo [this message]
2021-12-09 19:05 ` [PATCH] bpf: return EOPNOTSUPP when JIT is needed and not possible John Fastabend
2021-12-09 19:31 ` Ido Schimmel
2021-12-09 23:03 ` Daniel Borkmann
2021-12-10 2:23 ` Jakub Kicinski
2021-12-10 12:24 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209134038.41388-1-cascardo@canonical.com \
--to=cascardo@canonical.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox