From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org
Cc: kbuild-all@lists.01.org, bpf@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH bpf-next 4/5] bpf: remove the cgroup -> bpf header dependecy
Date: Wed, 15 Dec 2021 03:27:29 +0800 [thread overview]
Message-ID: <202112150326.PHRPQfmk-lkp@intel.com> (raw)
In-Reply-To: <20211213234223.356977-5-kuba@kernel.org>
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/bpf-remove-the-cgroup-bpf-header-dependecy/20211214-074344
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: s390-randconfig-r023-20211213 (https://download.01.org/0day-ci/archive/20211215/202112150326.PHRPQfmk-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/517f95dd6d9264e4104cfc35eecdd5c1287738ae
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/bpf-remove-the-cgroup-bpf-header-dependecy/20211214-074344
git checkout 517f95dd6d9264e4104cfc35eecdd5c1287738ae
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/s390/mm/hugetlbpage.c: In function 'hugetlb_get_unmapped_area':
>> arch/s390/mm/hugetlbpage.c:352:16: error: implicit declaration of function 'check_asce_limit'; did you mean 'check_data_rlimit'? [-Werror=implicit-function-declaration]
352 | return check_asce_limit(mm, addr, len);
| ^~~~~~~~~~~~~~~~
| check_data_rlimit
cc1: some warnings being treated as errors
vim +352 arch/s390/mm/hugetlbpage.c
5f490a520bcb393 Gerald Schaefer 2020-01-16 315
5f490a520bcb393 Gerald Schaefer 2020-01-16 316 unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
5f490a520bcb393 Gerald Schaefer 2020-01-16 317 unsigned long len, unsigned long pgoff, unsigned long flags)
5f490a520bcb393 Gerald Schaefer 2020-01-16 318 {
5f490a520bcb393 Gerald Schaefer 2020-01-16 319 struct hstate *h = hstate_file(file);
5f490a520bcb393 Gerald Schaefer 2020-01-16 320 struct mm_struct *mm = current->mm;
5f490a520bcb393 Gerald Schaefer 2020-01-16 321 struct vm_area_struct *vma;
5f490a520bcb393 Gerald Schaefer 2020-01-16 322
5f490a520bcb393 Gerald Schaefer 2020-01-16 323 if (len & ~huge_page_mask(h))
5f490a520bcb393 Gerald Schaefer 2020-01-16 324 return -EINVAL;
5f490a520bcb393 Gerald Schaefer 2020-01-16 325 if (len > TASK_SIZE - mmap_min_addr)
5f490a520bcb393 Gerald Schaefer 2020-01-16 326 return -ENOMEM;
5f490a520bcb393 Gerald Schaefer 2020-01-16 327
5f490a520bcb393 Gerald Schaefer 2020-01-16 328 if (flags & MAP_FIXED) {
5f490a520bcb393 Gerald Schaefer 2020-01-16 329 if (prepare_hugepage_range(file, addr, len))
5f490a520bcb393 Gerald Schaefer 2020-01-16 330 return -EINVAL;
5f490a520bcb393 Gerald Schaefer 2020-01-16 331 goto check_asce_limit;
5f490a520bcb393 Gerald Schaefer 2020-01-16 332 }
5f490a520bcb393 Gerald Schaefer 2020-01-16 333
5f490a520bcb393 Gerald Schaefer 2020-01-16 334 if (addr) {
5f490a520bcb393 Gerald Schaefer 2020-01-16 335 addr = ALIGN(addr, huge_page_size(h));
5f490a520bcb393 Gerald Schaefer 2020-01-16 336 vma = find_vma(mm, addr);
5f490a520bcb393 Gerald Schaefer 2020-01-16 337 if (TASK_SIZE - len >= addr && addr >= mmap_min_addr &&
5f490a520bcb393 Gerald Schaefer 2020-01-16 338 (!vma || addr + len <= vm_start_gap(vma)))
5f490a520bcb393 Gerald Schaefer 2020-01-16 339 goto check_asce_limit;
5f490a520bcb393 Gerald Schaefer 2020-01-16 340 }
5f490a520bcb393 Gerald Schaefer 2020-01-16 341
5f490a520bcb393 Gerald Schaefer 2020-01-16 342 if (mm->get_unmapped_area == arch_get_unmapped_area)
5f490a520bcb393 Gerald Schaefer 2020-01-16 343 addr = hugetlb_get_unmapped_area_bottomup(file, addr, len,
5f490a520bcb393 Gerald Schaefer 2020-01-16 344 pgoff, flags);
5f490a520bcb393 Gerald Schaefer 2020-01-16 345 else
5f490a520bcb393 Gerald Schaefer 2020-01-16 346 addr = hugetlb_get_unmapped_area_topdown(file, addr, len,
5f490a520bcb393 Gerald Schaefer 2020-01-16 347 pgoff, flags);
712fa5f294f377e Alexander Gordeev 2020-03-23 348 if (offset_in_page(addr))
5f490a520bcb393 Gerald Schaefer 2020-01-16 349 return addr;
5f490a520bcb393 Gerald Schaefer 2020-01-16 350
5f490a520bcb393 Gerald Schaefer 2020-01-16 351 check_asce_limit:
712fa5f294f377e Alexander Gordeev 2020-03-23 @352 return check_asce_limit(mm, addr, len);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-12-14 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 23:42 [PATCH bpf-next 0/5] bpf: remove the cgroup -> bpf header dependecy Jakub Kicinski
2021-12-13 23:42 ` [PATCH bpf-next 1/5] bpf: add header for enum bpf_cgroup_storage_type Jakub Kicinski
2021-12-13 23:42 ` [PATCH bpf-next 2/5] bpf: create a header for cgroup_storage_type() Jakub Kicinski
2021-12-13 23:42 ` [PATCH bpf-next 3/5] bpf: create a header for struct bpf_link Jakub Kicinski
2021-12-14 5:15 ` Alexei Starovoitov
2021-12-14 15:04 ` Jakub Kicinski
2021-12-14 15:18 ` Jakub Kicinski
2021-12-14 15:24 ` Jakub Kicinski
2021-12-13 23:42 ` [PATCH bpf-next 4/5] bpf: remove the cgroup -> bpf header dependecy Jakub Kicinski
2021-12-14 19:27 ` kernel test robot [this message]
2021-12-13 23:42 ` [PATCH bpf-next 5/5] bpf: push down the bpf-link include Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112150326.PHRPQfmk-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox