BPF List
 help / color / mirror / Atom feed
From: menglong8.dong@gmail.com
To: dsahern@kernel.org, kuba@kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, imagedong@tencent.com,
	edumazet@google.com, talalahmad@google.com,
	keescook@chromium.org, ilias.apalodimas@linaro.org,
	alobakin@pm.me, flyingpeng@tencent.com, mengensun@tencent.com,
	atenart@kernel.org, bigeasy@linutronix.de, memxor@gmail.com,
	arnd@arndb.de, pabeni@redhat.com, willemb@google.com,
	vvs@virtuozzo.com, cong.wang@bytedance.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Subject: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle_egress()
Date: Fri,  4 Mar 2022 01:47:01 +0800	[thread overview]
Message-ID: <20220303174707.40431-2-imagedong@tencent.com> (raw)
In-Reply-To: <20220303174707.40431-1-imagedong@tencent.com>

From: Menglong Dong <imagedong@tencent.com>

Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
The drop reason SKB_DROP_REASON_QDISC_EGRESS is introduced. Considering
the code path of qdisc egerss, we make it distinct with the drop reason
of SKB_DROP_REASON_QDISC_DROP in the next commit.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 include/linux/skbuff.h     | 4 ++++
 include/trace/events/skb.h | 1 +
 net/core/dev.c             | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index d67941f78b92..ebd18850b63e 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -394,6 +394,10 @@ enum skb_drop_reason {
 						 * entry is full
 						 */
 	SKB_DROP_REASON_NEIGH_DEAD,	/* neigh entry is dead */
+	SKB_DROP_REASON_QDISC_EGRESS,	/* qdisc of type egress check
+					 * failed (mapbe an eBPF program
+					 * is tricking?)
+					 */
 	SKB_DROP_REASON_MAX,
 };
 
diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index 1977f301260d..3cadf13448c6 100644
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -45,6 +45,7 @@
 	EM(SKB_DROP_REASON_NEIGH_FAILED, NEIGH_FAILED)		\
 	EM(SKB_DROP_REASON_NEIGH_QUEUEFULL, NEIGH_QUEUEFULL)	\
 	EM(SKB_DROP_REASON_NEIGH_DEAD, NEIGH_DEAD)		\
+	EM(SKB_DROP_REASON_QDISC_EGRESS, QDISC_EGRESS)		\
 	EMe(SKB_DROP_REASON_MAX, MAX)
 
 #undef EM
diff --git a/net/core/dev.c b/net/core/dev.c
index 2d6771075720..828946d74a19 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3860,7 +3860,7 @@ sch_handle_egress(struct sk_buff *skb, int *ret, struct net_device *dev)
 	case TC_ACT_SHOT:
 		mini_qdisc_qstats_cpu_drop(miniq);
 		*ret = NET_XMIT_DROP;
-		kfree_skb(skb);
+		kfree_skb_reason(skb, SKB_DROP_REASON_QDISC_EGRESS);
 		return NULL;
 	case TC_ACT_STOLEN:
 	case TC_ACT_QUEUED:
-- 
2.35.1


  reply	other threads:[~2022-03-03 17:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 17:47 [PATCH net-next 0/7] net: dev: add skb drop reasons to net/core/dev.c menglong8.dong
2022-03-03 17:47 ` menglong8.dong [this message]
2022-03-04  4:25   ` [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle_egress() Jakub Kicinski
2022-03-04  4:56     ` Menglong Dong
2022-03-04  5:05       ` Jakub Kicinski
2022-03-04  5:19         ` Menglong Dong
2022-03-03 17:47 ` [PATCH net-next 2/7] net: skb: introduce the function kfree_skb_list_reason() menglong8.dong
2022-03-04  0:12   ` Dongli Zhang
2022-03-04  4:06     ` Jakub Kicinski
2022-03-03 17:47 ` [PATCH net-next 3/7] net: dev: add skb drop reasons to __dev_xmit_skb() menglong8.dong
2022-03-03 17:47 ` [PATCH net-next 4/7] net: dev: use kfree_skb_reason() for enqueue_to_backlog() menglong8.dong
2022-03-03 17:59   ` Eric Dumazet
2022-03-04  4:40     ` Menglong Dong
2022-03-03 17:47 ` [PATCH net-next 5/7] net: dev: use kfree_skb_reason() for do_xdp_generic() menglong8.dong
2022-03-03 17:47 ` [PATCH net-next 6/7] net: dev: use kfree_skb_reason() for sch_handle_ingress() menglong8.dong
2022-03-03 17:47 ` [PATCH net-next 7/7] net: dev: use kfree_skb_reason() for __netif_receive_skb_core() menglong8.dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303174707.40431-2-imagedong@tencent.com \
    --to=menglong8.dong@gmail.com \
    --cc=alobakin@pm.me \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=atenart@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=flyingpeng@tencent.com \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=imagedong@tencent.com \
    --cc=john.fastabend@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=mengensun@tencent.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=talalahmad@google.com \
    --cc=vvs@virtuozzo.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox