BPF List
 help / color / mirror / Atom feed
From: menglong8.dong@gmail.com
To: dsahern@kernel.org, kuba@kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, imagedong@tencent.com,
	edumazet@google.com, talalahmad@google.com,
	keescook@chromium.org, ilias.apalodimas@linaro.org,
	alobakin@pm.me, flyingpeng@tencent.com, mengensun@tencent.com,
	atenart@kernel.org, bigeasy@linutronix.de, memxor@gmail.com,
	arnd@arndb.de, pabeni@redhat.com, willemb@google.com,
	vvs@virtuozzo.com, cong.wang@bytedance.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Subject: [PATCH net-next v2 2/7] net: skb: introduce the function kfree_skb_list_reason()
Date: Fri,  4 Mar 2022 14:00:41 +0800	[thread overview]
Message-ID: <20220304060046.115414-3-imagedong@tencent.com> (raw)
In-Reply-To: <20220304060046.115414-1-imagedong@tencent.com>

From: Menglong Dong <imagedong@tencent.com>

To report reasons of skb drops, introduce the function
kfree_skb_list_reason() and make kfree_skb_list() an inline call to
it. This function will be used in the next commit in
__dev_xmit_skb().

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 include/linux/skbuff.h | 8 +++++++-
 net/core/skbuff.c      | 7 ++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 4328dfc3281c..9d219e266dc7 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1191,10 +1191,16 @@ static inline void kfree_skb(struct sk_buff *skb)
 }
 
 void skb_release_head_state(struct sk_buff *skb);
-void kfree_skb_list(struct sk_buff *segs);
+void kfree_skb_list_reason(struct sk_buff *segs,
+			   enum skb_drop_reason reason);
 void skb_dump(const char *level, const struct sk_buff *skb, bool full_pkt);
 void skb_tx_error(struct sk_buff *skb);
 
+static inline void kfree_skb_list(struct sk_buff *segs)
+{
+	kfree_skb_list_reason(segs, SKB_DROP_REASON_NOT_SPECIFIED);
+}
+
 #ifdef CONFIG_TRACEPOINTS
 void consume_skb(struct sk_buff *skb);
 #else
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index b32c5d782fe1..46d7dea78011 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -777,16 +777,17 @@ void kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason)
 }
 EXPORT_SYMBOL(kfree_skb_reason);
 
-void kfree_skb_list(struct sk_buff *segs)
+void kfree_skb_list_reason(struct sk_buff *segs,
+			   enum skb_drop_reason reason)
 {
 	while (segs) {
 		struct sk_buff *next = segs->next;
 
-		kfree_skb(segs);
+		kfree_skb_reason(segs, reason);
 		segs = next;
 	}
 }
-EXPORT_SYMBOL(kfree_skb_list);
+EXPORT_SYMBOL(kfree_skb_list_reason);
 
 /* Dump skb information and contents.
  *
-- 
2.35.1


  parent reply	other threads:[~2022-03-04  6:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  6:00 [PATCH net-next v2 0/7] net: dev: add skb drop reasons to net/core/dev.c menglong8.dong
2022-03-04  6:00 ` [PATCH net-next v2 1/7] net: dev: use kfree_skb_reason() for sch_handle_egress() menglong8.dong
2022-03-04  6:00 ` menglong8.dong [this message]
2022-03-04  6:00 ` [PATCH net-next v2 3/7] net: dev: add skb drop reasons to __dev_xmit_skb() menglong8.dong
2022-03-04  6:00 ` [PATCH net-next v2 4/7] net: dev: use kfree_skb_reason() for enqueue_to_backlog() menglong8.dong
2022-03-04  6:00 ` [PATCH net-next v2 5/7] net: dev: use kfree_skb_reason() for do_xdp_generic() menglong8.dong
2022-03-04  6:00 ` [PATCH net-next v2 6/7] net: dev: use kfree_skb_reason() for sch_handle_ingress() menglong8.dong
2022-03-04  6:00 ` [PATCH net-next v2 7/7] net: dev: use kfree_skb_reason() for __netif_receive_skb_core() menglong8.dong
2022-03-04 12:30 ` [PATCH net-next v2 0/7] net: dev: add skb drop reasons to net/core/dev.c patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304060046.115414-3-imagedong@tencent.com \
    --to=menglong8.dong@gmail.com \
    --cc=alobakin@pm.me \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=atenart@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=flyingpeng@tencent.com \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=imagedong@tencent.com \
    --cc=john.fastabend@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=mengensun@tencent.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=talalahmad@google.com \
    --cc=vvs@virtuozzo.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox