BPF List
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Song Liu <song@kernel.org>, bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, kernel-team@fb.com, edumazet@google.com,
	Song Liu <song@kernel.org>
Subject: Re: [PATCH v3 bpf-next] bpf: select proper size for bpf_prog_pack
Date: Sat, 12 Mar 2022 05:40:31 +0800	[thread overview]
Message-ID: <202203120545.dI2S3hTQ-lkp@intel.com> (raw)
In-Reply-To: <20220309183523.3308210-1-song@kernel.org>

Hi Song,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Song-Liu/bpf-select-proper-size-for-bpf_prog_pack/20220310-023737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-c002-20220311 (https://download.01.org/0day-ci/archive/20220312/202203120545.dI2S3hTQ-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4d06f388e14c69d938cbc1e4081029c14d8bc654
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Song-Liu/bpf-select-proper-size-for-bpf_prog_pack/20220310-023737
        git checkout 4d06f388e14c69d938cbc1e4081029c14d8bc654
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/bpf/core.c: In function 'select_bpf_prog_pack_size':
>> kernel/bpf/core.c:846:16: error: 'PMD_SIZE' undeclared (first use in this function); did you mean 'P4D_SIZE'?
     846 |         size = PMD_SIZE * num_online_nodes();
         |                ^~~~~~~~
         |                P4D_SIZE
   kernel/bpf/core.c:846:16: note: each undeclared identifier is reported only once for each function it appears in


vim +846 kernel/bpf/core.c

   840	
   841	static size_t select_bpf_prog_pack_size(void)
   842	{
   843		size_t size;
   844		void *ptr;
   845	
 > 846		size = PMD_SIZE * num_online_nodes();
   847		ptr = module_alloc(size);
   848	
   849		/* Test whether we can get huge pages. If not just use PAGE_SIZE
   850		 * packs.
   851		 */
   852		if (!ptr || !is_vm_area_hugepages(ptr))
   853			size = PAGE_SIZE;
   854	
   855		vfree(ptr);
   856		return size;
   857	}
   858	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

  reply	other threads:[~2022-03-11 22:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 18:35 [PATCH v3 bpf-next] bpf: select proper size for bpf_prog_pack Song Liu
2022-03-11 21:40 ` kernel test robot [this message]
2022-03-11 23:06 ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203120545.dI2S3hTQ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=edumazet@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox