From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02FEDC433F5 for ; Tue, 15 Mar 2022 10:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245566AbiCOKlI (ORCPT ); Tue, 15 Mar 2022 06:41:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346276AbiCOKlH (ORCPT ); Tue, 15 Mar 2022 06:41:07 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A924F45E; Tue, 15 Mar 2022 03:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1JxXCLRRx9EmLaXlGQy1h++6/IueE36Jv1DWaZM2tjg=; b=AT/LI771Q4OcRgJCZ7lfp2BISN 8QrmadvMef20IywRDxwvQX95A3BEXpfuKZJ5m6VMqSvOpWH4T/E9c+fXvQwoMGZnCWJaNhP/X8l+C jTrxLBdNzRLaPh0Ga79wjQrtct+LivoeKFpsWPXLginu6r6zcArvAIsToWhpxrMogrOfNs7OIc6hq dzfbVzBJ1y8hAQ6heg41OVBMhIQ4r0+GtYjHbdYj3GPMmTazKH7RcUTje8i9Sc4pi+XME9026UhDO Q8110wB7ry4qsMi4KhS6yzfK5cVVOi9n/33LrXOBBw38ca0ESj2XsW2Ckd9RxCaui+aKFYEd45/tS uA6mOuCw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU4aN-001Bts-Gm; Tue, 15 Mar 2022 10:39:27 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 73C5098620D; Tue, 15 Mar 2022 11:39:25 +0100 (CET) Date: Tue, 15 Mar 2022 11:39:25 +0100 From: Peter Zijlstra To: Kumar Kartikeya Dwivedi Cc: Alexei Starovoitov , X86 ML , joao@overdrivepizza.com, hjl.tools@gmail.com, Josh Poimboeuf , Andrew Cooper , LKML , Nick Desaulniers , Kees Cook , Sami Tolvanen , Mark Rutland , alyssa.milburn@intel.com, Miroslav Benes , Steven Rostedt , Masami Hiramatsu , Daniel Borkmann , Andrii Nakryiko , bpf Subject: Re: [PATCH v4 00/45] x86: Kernel IBT Message-ID: <20220315103925.GB14330@worktop.programming.kicks-ass.net> References: <20220312154407.GF28057@worktop.programming.kicks-ass.net> <20220314204402.rpd5hqzzev4ugtdt@apollo> <20220315090043.GB8939@worktop.programming.kicks-ass.net> <20220315100706.GA14330@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220315100706.GA14330@worktop.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Mar 15, 2022 at 11:07:06AM +0100, Peter Zijlstra wrote: > On Tue, Mar 15, 2022 at 10:00:43AM +0100, Peter Zijlstra wrote: > > I don't seem able to run this mod_race test, it keeps saying: > > > > tgl-build# ./test_progs -v -t mod_race > > bpf_testmod.ko is already unloaded. > > Loading bpf_testmod.ko... > > Successfully loaded bpf_testmod.ko. > > Summary: 0/0 PASSED, 0 SKIPPED, 0 FAILED > > Successfully unloaded bpf_testmod.ko. > > > > Which I'm taking to mean I'm doing it wrong... > > That.. I was building the wrong tree, mod_race comes from bpf-next and I > was building a tree without that merged in... let me to see what it does > now. I can confirm, crashes without, fixed with. Thanks! I've forced pushed a cleaned up tip/x86/core. Also: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/ibt.bpf is a merge of that and bpf-next