From: Masami Hiramatsu <mhiramat@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH bpf-next 0/2] bpf: Fix kprobe_multi return probe backtrace
Date: Tue, 22 Mar 2022 09:53:15 +0900 [thread overview]
Message-ID: <20220322095315.3753d18ef8b3dfb69e0a995d@kernel.org> (raw)
In-Reply-To: <20220321070113.1449167-1-jolsa@kernel.org>
On Mon, 21 Mar 2022 08:01:11 +0100
Jiri Olsa <jolsa@kernel.org> wrote:
> hi,
> Andrii reported that backtraces from kprobe_multi program attached
> as return probes are not complete and showing just initial entry [1].
>
> Sending the fix together with bpf_get_func_ip inline revert, which is
> no longer suitable.
OK, this series looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
>
> thanks,
> jirka
>
>
> ---
> [1] https://lore.kernel.org/bpf/CAEf4BzZDDqK24rSKwXNp7XL3ErGD4bZa1M6c_c4EvDSt3jrZcg@mail.gmail.com/T/#m8d1301c0ea0892ddf9dc6fba57a57b8cf11b8c51
>
> Jiri Olsa (2):
> Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"
> bpf: Fix kprobe_multi return probe backtrace
>
> kernel/bpf/verifier.c | 21 +--------------------
> kernel/trace/bpf_trace.c | 68 +++++++++++++++++++++++++++++++++++++-------------------------------
> 2 files changed, 38 insertions(+), 51 deletions(-)
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2022-03-22 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 7:01 [PATCH bpf-next 0/2] bpf: Fix kprobe_multi return probe backtrace Jiri Olsa
2022-03-21 7:01 ` [PATCH bpf-next 1/2] Revert "bpf: Add support to inline bpf_get_func_ip helper on x86" Jiri Olsa
2022-03-21 7:01 ` [PATCH bpf-next 2/2] bpf: Fix kprobe_multi return probe backtrace Jiri Olsa
2022-03-21 14:00 ` [PATCH bpf-next 0/2] " patchwork-bot+netdevbpf
2022-03-22 0:53 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322095315.3753d18ef8b3dfb69e0a995d@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox