From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82591C433EF for ; Fri, 1 Apr 2022 09:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245170AbiDAJ2T (ORCPT ); Fri, 1 Apr 2022 05:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244634AbiDAJ2S (ORCPT ); Fri, 1 Apr 2022 05:28:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB772FA22B; Fri, 1 Apr 2022 02:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zD1bh8zBdF6SWEbtcuaNiNWduZj2pRO29dlVMIKrE7w=; b=q4bzTMMtSJLueTsGJcO/34ysUf wyz9AQNc0dJ3tUyivpAw4uGN+3qThn7qqycBSDot6XOLEeD5YGQ1VNEUQV8X+Dzkn9dg4SKkgVoQV IjVXUjTTMHhQCGjjWzQjmucW6GB4fR194p4vmecZF2ouped3zOnRKYU9GwkHqb6WLgrBmpX8nksta 5p4tOd3I8CdGlAtEvGgFqgJudyNuHyxEOidXQcJNBMa8A8e0CoccoPzhZtSMFCusH8a+81q1qokJR yGTw6U+gJA9bQMziZ0usxZ0DYgClHXU1kzgCCEwI+0F3q2WNJG2D7H2sw7TAYwxUAmR+jR6VHTfM6 tHJTFp7Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDXe-0033hJ-7N; Fri, 01 Apr 2022 09:26:02 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id E05619861EB; Fri, 1 Apr 2022 11:25:59 +0200 (CEST) Date: Fri, 1 Apr 2022 11:25:59 +0200 From: Peter Zijlstra To: Namhyung Kim Cc: Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , LKML , Thomas Gleixner , Steven Rostedt , Byungchul Park , "Paul E. McKenney" , Mathieu Desnoyers , Arnd Bergmann , Radoslaw Burny , linux-arch , bpf , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH 2/2] locking: Apply contention tracepoints in the slow path Message-ID: <20220401092559.GW8939@worktop.programming.kicks-ass.net> References: <20220322185709.141236-1-namhyung@kernel.org> <20220322185709.141236-3-namhyung@kernel.org> <20220328113946.GA8939@worktop.programming.kicks-ass.net> <20220330110853.GK8939@worktop.programming.kicks-ass.net> <20220331115916.GU8939@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Mar 31, 2022 at 11:26:17PM -0700, Namhyung Kim wrote: > On Thu, Mar 31, 2022 at 01:59:16PM +0200, Peter Zijlstra wrote: > > I've since pushed out the lot to: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core > > > > It builds, but I've not actually used it. Much appreciated if you could > > test. > > > > I've tested it and it worked well. Thanks for your work! > > And we need to add the below too.. Thanks > ----8<---- > > diff --git a/include/trace/events/lock.h b/include/trace/events/lock.h > index db5bdbb9b9c0..9463a93132c3 100644 > --- a/include/trace/events/lock.h > +++ b/include/trace/events/lock.h > @@ -114,7 +114,8 @@ TRACE_EVENT(contention_begin, > { LCB_F_READ, "READ" }, > { LCB_F_WRITE, "WRITE" }, > { LCB_F_RT, "RT" }, > - { LCB_F_PERCPU, "PERCPU" } > + { LCB_F_PERCPU, "PERCPU" }, > + { LCB_F_MUTEX, "MUTEX" } > )) > ); Duh, indeed, folded!