BPF List
 help / color / mirror / Atom feed
From: David Vernet <void@manifault.com>
To: "Daniel Müller" <deso@posteo.net>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
	daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next] Enable CONFIG_FPROBE for self tests
Date: Wed, 11 May 2022 10:27:28 -0700	[thread overview]
Message-ID: <20220511172728.wtaojbqsdpm7mang@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <20220511172249.4082510-1-deso@posteo.net>

On Wed, May 11, 2022 at 05:22:49PM +0000, Daniel Müller wrote:
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
> 
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
> 
> The cause of these is that CONFIG_FPROBE is missing. With this change we
> add this configuration value to the BPF selftests config.
> 
> Signed-off-by: Daniel Müller <deso@posteo.net>
> ---
>  tools/testing/selftests/bpf/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
> index 763db6..08c6e5a 100644
> --- a/tools/testing/selftests/bpf/config
> +++ b/tools/testing/selftests/bpf/config
> @@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
>  CONFIG_NF_DEFRAG_IPV6=y
>  CONFIG_NF_CONNTRACK=y
>  CONFIG_USERFAULTFD=y
> +CONFIG_FPROBE=y
> -- 
> 2.30.2
> 

Looks good, thanks Daniel.

Acked-by: David Vernet <void@manifault.com>

  reply	other threads:[~2022-05-11 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 17:22 [PATCH bpf-next] Enable CONFIG_FPROBE for self tests Daniel Müller
2022-05-11 17:27 ` David Vernet [this message]
2022-05-11 19:05 ` Alexei Starovoitov
2022-05-11 19:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220511172728.wtaojbqsdpm7mang@dev0025.ash9.facebook.com \
    --to=void@manifault.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=deso@posteo.net \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox