From: Eduard Zingerman <eddyz87@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com,
dan.carpenter@oracle.com
Cc: eddyz87@gmail.com
Subject: [PATCH bpf-next 0/2] bpf: fix for use after free bug in inline_bpf_loop
Date: Fri, 24 Jun 2022 05:06:11 +0300 [thread overview]
Message-ID: <20220624020613.548108-1-eddyz87@gmail.com> (raw)
These two patches fix the use after free bug in inline_bpf_loop()
reported by Dan Carpenter. The fix for verifier.c and the test case in
test_verifier.c are split into separate commits.
While the first patch is necessary, I'm not sure about the second. The
test case is somewhat fragile because of the following line:
const int len = getpagesize() - 25;
Here 25 is a magical number that allows env->prog to fit in one page
before bpf_loop inlining and don't fit after the bpf_loop
inlining. I'd prefer to use sizeof(struct bpf_prog) instead of this
constant, but definition of the struct bpf_prog is not available in
test_verifier.c.
Eduard Zingerman (2):
bpf: fix for use after free bug in inline_bpf_loop
selftest/bpf: test for use after free bug fix in inline_bpf_loop
kernel/bpf/verifier.c | 2 +-
tools/testing/selftests/bpf/test_verifier.c | 39 +++++++++++++++++++
.../selftests/bpf/verifier/bpf_loop_inline.c | 11 ++++++
3 files changed, 51 insertions(+), 1 deletion(-)
--
2.25.1
next reply other threads:[~2022-06-24 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 2:06 Eduard Zingerman [this message]
2022-06-24 2:06 ` [PATCH bpf-next 1/2] bpf: fix for use after free bug in inline_bpf_loop Eduard Zingerman
2022-06-24 2:06 ` [PATCH bpf-next 2/2] selftest/bpf: test for use after free bug fix " Eduard Zingerman
2022-06-24 15:10 ` [PATCH bpf-next 0/2] bpf: fix for use after free bug " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624020613.548108-1-eddyz87@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox