From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01E3C43334 for ; Thu, 14 Jul 2022 14:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238604AbiGNOEs (ORCPT ); Thu, 14 Jul 2022 10:04:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239536AbiGNOEX (ORCPT ); Thu, 14 Jul 2022 10:04:23 -0400 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FB8EF52 for ; Thu, 14 Jul 2022 07:04:19 -0700 (PDT) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 85A09240029 for ; Thu, 14 Jul 2022 16:04:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1657807457; bh=+Iejk6zjmyB7Ku3EdMoEpviBalwkdZ4QP9iOgvS2wQU=; h=Date:From:To:Cc:Subject:From; b=BBP7MlKRclt6yts2/bEmie/epccrZtX8uL9qZxxDSbAOcW0OKNW7XFZMYn3HFPhO0 3TgPS8HquoRDPPwYOhR2y+eNAQPF7pRfdjdXM1hHtOy0pa/IMwXWqhe+WfVAiD5MFQ fXdkYMxlbOqb6DR8/nTovMiP1RVe8tRibtbm2DHMj/Hr3jbLKoA/xSHl7i9LI0cfhN llJQkT7LURUF2wTh+4MoU7ygtCtOa1OXhUGs40TwZ+n+LiafWxGc+GLXEyiBc41aZZ 9qbIC7/rr0pHMdHdo0OKoVnVwf+b7tRtVzcZblC5dGtMrZhKtrhmpQrQaJ4tIFKiLh bpfZ4okzo54nw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LkGSZ1hQPz9rxT; Thu, 14 Jul 2022 16:04:14 +0200 (CEST) Date: Thu, 14 Jul 2022 14:04:10 +0000 From: Daniel =?utf-8?Q?M=C3=BCller?= To: Andrii Nakryiko Cc: bpf , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Kernel Team , Mykola Lysenko Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Integrate vmtest configs Message-ID: <20220714140410.ccvmj2ib5reamdmg@nuc> References: <20220712212124.3180314-1-deso@posteo.net> <20220712212124.3180314-3-deso@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jul 13, 2022 at 10:07:02PM -0700, Andrii Nakryiko wrote: > On Tue, Jul 12, 2022 at 2:21 PM Daniel Müller wrote: > > > > This change integrates the configuration from the vmtest repository [0], > > where it is currently used for testing kernel patches into the existing > > configuration pulled in with an earlier patch. The result is a super set > > of the configs from the two repositories. > > > > [0]: https://github.com/kernel-patches/vmtest/tree/831ee8eb72ddb7e03babb8f7e050d52a451237aa/travis-ci/vmtest/configs > > > > Signed-off-by: Daniel Müller > > --- > > tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest | 5 +++++ > > .../selftests/bpf/configs/denylist/DENYLIST-latest.s390x | 1 + > > 2 files changed, 6 insertions(+) > > > > diff --git a/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest b/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest > > index 939de574..ddf8a0c5 100644 > > --- a/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest > > +++ b/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest > > @@ -4,3 +4,8 @@ stacktrace_build_id_nmi > > stacktrace_build_id > > task_fd_query_rawtp > > varlen > > +btf_dump/btf_dump: syntax > > +kprobe_multi_test/bench_attach > > +core_reloc/enum64val > > +core_reloc/size___diff_sz > > +core_reloc/type_based___diff_sz > > I don't think any of these are necessary anymore. Some of them were > due to nightly Clang was stale. > > > diff --git a/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest.s390x b/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest.s390x > > index e33cab..36574b0 100644 > > --- a/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest.s390x > > +++ b/tools/testing/selftests/bpf/configs/denylist/DENYLIST-latest.s390x > > @@ -63,5 +63,6 @@ bpf_cookie # failed to open_and_load program: -524 > > xdp_do_redirect # prog_run_max_size unexpected error: -22 (errno 22) > > send_signal # intermittently fails to receive signal > > select_reuseport # intermittently fails on new s390x setup > > +tc_redirect/tc_redirect_dtime # very flaky > > same for this, yes it's flaky, but this shouldn't be in this list (I'd > rather people actually fix the flakiness, of course). These configs > should be "known not working" test cases (e.g., like BPF > trampoline-based for s390x, that feature is just not implemented). But > flaky tests should go here, they should be ideally fixed and not be > blessed officially to be ignored. I can remove this change from the set. But really from my perspective the entire patch set's concern is not with cleaning up any of the lists -- it is about merging and integrating existing configuration from two others repositories into this one, while preserving what has been done and why in a way that can be followed when looking back at repository histories. My observation has been that at least on x86_64, none of the denied tests caused actual failures when run. And yet, that is best cleaned up subsequently if it were for me. Thanks, Daniel