From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Alan Maguire <alan.maguire@oracle.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] libbpf: fix str_has_sfx()
Date: Tue, 19 Jul 2022 20:50:48 +0300 [thread overview]
Message-ID: <20220719175048.GC2316@kadam> (raw)
In-Reply-To: <20220719171902.37gvquchuwf5e4gh@kafai-mbp.dhcp.thefacebook.com>
On Tue, Jul 19, 2022 at 10:19:02AM -0700, Martin KaFai Lau wrote:
> > @@ -108,9 +108,9 @@ static inline bool str_has_sfx(const char *str, const char *sfx)
> > size_t str_len = strlen(str);
> > size_t sfx_len = strlen(sfx);
> >
> > - if (sfx_len <= str_len)
> > - return strcmp(str + str_len - sfx_len, sfx);
> > - return false;
> > + if (sfx_len > str_len)
> > + return false;
> > + return strcmp(str + str_len - sfx_len, sfx) == 0;
> Please tag the subject with "bpf" next time.
I always work against linux-next. Would it help if I put that in the
subject?
Otherwise I don't have a way to figure this stuff out. I kind of know
networking tree but not 100% and that is a massive pain in the butt.
Until there is an automated way that then those kind of requests are
not reasonable.
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-19 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:53 [PATCH] libbpf: fix str_has_sfx() Dan Carpenter
2022-07-19 17:19 ` Martin KaFai Lau
2022-07-19 17:50 ` Dan Carpenter [this message]
2022-07-19 17:54 ` Alexei Starovoitov
2022-07-20 9:11 ` Dan Carpenter
2022-07-19 17:51 ` Alexei Starovoitov
2022-07-20 7:37 ` Alan Maguire
2022-07-28 22:10 ` Andrii Nakryiko
2022-07-21 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719175048.GC2316@kadam \
--to=dan.carpenter@oracle.com \
--cc=alan.maguire@oracle.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox