From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A56C00140 for ; Wed, 10 Aug 2022 17:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233237AbiHJRHU (ORCPT ); Wed, 10 Aug 2022 13:07:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233254AbiHJRHM (ORCPT ); Wed, 10 Aug 2022 13:07:12 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F21827757C for ; Wed, 10 Aug 2022 10:07:10 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-31f56f635a9so130397987b3.4 for ; Wed, 10 Aug 2022 10:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc; bh=NDKj9WvDVcpp72e/Jq/GTiPcROFKNcyaGjJEdm/L+Ts=; b=X9e/GgluQJANDKFV0jFwlXW00XKEjHhjfO/brvre3Gw5uNpgSHsWoIi8QDqA4wt8zk CexRXMYl9XeZtcQ1hg2op+YKm38bo0z4cWq8rCwG5+wrjzrUOJSInGLpcRNPTKVPxD8J TQJ02+pc3eBFY+XQ/1/w34xfwA9dtKzVGX0nmZGQMjB+MdAlDz3bkz8mMF91BWMCEFEt j+/QOmPEv9/ryDVEy/xsPy0lJGhPCSW59i60SFbFZp6JphxcmA71yWhTiw3oKJzNgwnu XoWreqyMPwsntxrmAakC9gUG0oYWZ4lVDH7xx1MiVudxtJgaYpbfsUUkgBjahjMLoLq3 i1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc; bh=NDKj9WvDVcpp72e/Jq/GTiPcROFKNcyaGjJEdm/L+Ts=; b=6pAN5rUZH7Lx+Es7fFCHdN3mQt4iaevt1ZtVcIvPSRU/aB/6VG+z4Nn01pyRnjHOoQ 2um3n7bwOg2+Ob3lGnzlLEnZXruBT5RRFYVbcRW6+xKC8xzSPubHhWhh+RaUrmC0N517 2Q3rm/zK9n1gL9jP8CAh/O4K2OryPMFBQiJQbiYUiiPlJPHrNj8fsuxBJV2GSWwpBF0Y ofuRdO6BVPAjrDu7PK3A5hAiXUcI7afsTPisDl6MZzSGpwBT4cOJBuqm/ToLfYxNvQAd 7TJ1PlntW2OdGmkL13rrevlNLS9SipBEToJhIlIIfV2AF7vepUpPM3DvlXJnH0plhK/G u6gA== X-Gm-Message-State: ACgBeo2Ew66R9gIM4fO8FoXBfWc6lgBV9AuOmQ9cLVNeVWNcULw5YjgM huU0xI4TGe1iItR0XFS5yvjdheOgTF6dyQ== X-Google-Smtp-Source: AA6agR40+GyN7iMi/+y8+SEnXgz5d1sWTF6KBR9mZOrYJz5MsqI+gArikvEGD0ucx6p3tDpnZos8Ahi8w8vEZQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a25:cb4f:0:b0:677:5f49:99e6 with SMTP id b76-20020a25cb4f000000b006775f4999e6mr25934323ybg.338.1660151229736; Wed, 10 Aug 2022 10:07:09 -0700 (PDT) Date: Wed, 10 Aug 2022 17:07:06 +0000 In-Reply-To: <20220810151840.16394-6-laoar.shao@gmail.com> Message-Id: <20220810170706.ikyrsuzupjwt65h7@google.com> Mime-Version: 1.0 References: <20220810151840.16394-1-laoar.shao@gmail.com> <20220810151840.16394-6-laoar.shao@gmail.com> Subject: Re: [PATCH bpf-next 05/15] bpf: Fix incorrect mem_cgroup_put From: Shakeel Butt To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, akpm@linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Aug 10, 2022 at 03:18:30PM +0000, Yafang Shao wrote: > The memcg may be the root_mem_cgroup, in which case we shouldn't put it. No, it is ok to put root_mem_cgroup. css_put already handles the root cgroups.