public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Xu <dxu@dxuuu.xyz>,
	bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, memxor@gmail.com
Cc: kbuild-all@lists.01.org, Daniel Xu <dxu@dxuuu.xyz>,
	pablo@netfilter.org, fw@strlen.de, toke@kernel.org,
	martin.lau@linux.dev, netfilter-devel@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 4/5] bpf: Add support for writing to nf_conn:mark
Date: Tue, 23 Aug 2022 21:49:40 +0800	[thread overview]
Message-ID: <202208232110.vsR1bsL0-lkp@intel.com> (raw)
In-Reply-To: <073173502d762faf87bde0ca23e609c84848dd7e.1661192455.git.dxu@dxuuu.xyz>

Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Xu/bpf-Remove-duplicate-PTR_TO_BTF_ID-RO-check/20220823-032643
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220823/202208232110.vsR1bsL0-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/496ec6d75c8e8758f93c6b987eee83713c911a05
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Xu/bpf-Remove-duplicate-PTR_TO_BTF_ID-RO-check/20220823-032643
        git checkout 496ec6d75c8e8758f93c6b987eee83713c911a05
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: net/core/filter.o: in function `tc_cls_act_btf_struct_access':
   net/core/filter.c:8644: undefined reference to `nf_conntrack_btf_struct_access'
   ld: net/core/filter.o: in function `xdp_btf_struct_access':
>> include/net/net_namespace.h:369: undefined reference to `nf_conntrack_btf_struct_access'
   pahole: .tmp_vmlinux.btf: Invalid argument
   .btf.vmlinux.bin.o: file not recognized: file format not recognized


vim +369 include/net/net_namespace.h

8f424b5f32d78b Eric Dumazet      2008-11-12  365  
0c5c9fb5510633 Eric W. Biederman 2015-03-11  366  static inline struct net *read_pnet(const possible_net_t *pnet)
8f424b5f32d78b Eric Dumazet      2008-11-12  367  {
0c5c9fb5510633 Eric W. Biederman 2015-03-11  368  #ifdef CONFIG_NET_NS
0c5c9fb5510633 Eric W. Biederman 2015-03-11 @369  	return pnet->net;
8f424b5f32d78b Eric Dumazet      2008-11-12  370  #else
0c5c9fb5510633 Eric W. Biederman 2015-03-11  371  	return &init_net;
8f424b5f32d78b Eric Dumazet      2008-11-12  372  #endif
0c5c9fb5510633 Eric W. Biederman 2015-03-11  373  }
5d1e4468a7705d Denis V. Lunev    2008-04-16  374  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  parent reply	other threads:[~2022-08-23 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 18:25 [PATCH bpf-next v4 0/5] Support direct writes to nf_conn:mark Daniel Xu
2022-08-22 18:25 ` [PATCH bpf-next v4 1/5] bpf: Remove duplicate PTR_TO_BTF_ID RO check Daniel Xu
2022-08-22 18:25 ` [PATCH bpf-next v4 2/5] bpf: Add stub for btf_struct_access() Daniel Xu
2022-08-22 18:25 ` [PATCH bpf-next v4 3/5] bpf: Use 0 instead of NOT_INIT for btf_struct_access() writes Daniel Xu
2022-08-22 18:25 ` [PATCH bpf-next v4 4/5] bpf: Add support for writing to nf_conn:mark Daniel Xu
2022-08-23  0:16   ` Kumar Kartikeya Dwivedi
2022-08-23  2:19     ` Daniel Xu
2022-08-23  2:29       ` Kumar Kartikeya Dwivedi
2022-09-07  2:35         ` Daniel Xu
2022-08-23 13:49   ` kernel test robot [this message]
2022-09-02 12:16   ` kernel test robot
2022-08-22 18:25 ` [PATCH bpf-next v4 5/5] selftests/bpf: Add tests " Daniel Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202208232110.vsR1bsL0-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dxu@dxuuu.xyz \
    --cc=fw@strlen.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=toke@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox