From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Stanislav Fomichev" <sdf@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH bpf-next v2 1/3] dev: Move received_rps counter next to RPS members in softnet data
Date: Mon, 5 Sep 2022 21:33:57 +0200 [thread overview]
Message-ID: <20220905193359.969347-2-toke@redhat.com> (raw)
In-Reply-To: <20220905193359.969347-1-toke@redhat.com>
Move the received_rps counter value next to the other RPS-related members
in softnet_data. This closes two four-byte holes in the structure, making
room for another pointer in the first two cache lines without bumping the
xmit struct to its own line.
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 1a3cb93c3dcc..fe9aeca2fce9 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3100,7 +3100,6 @@ struct softnet_data {
/* stats */
unsigned int processed;
unsigned int time_squeeze;
- unsigned int received_rps;
#ifdef CONFIG_RPS
struct softnet_data *rps_ipi_list;
#endif
@@ -3133,6 +3132,7 @@ struct softnet_data {
unsigned int cpu;
unsigned int input_queue_tail;
#endif
+ unsigned int received_rps;
unsigned int dropped;
struct sk_buff_head input_pkt_queue;
struct napi_struct backlog;
--
2.37.2
next prev parent reply other threads:[~2022-09-05 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 19:33 [PATCH bpf-next v2 0/3] A couple of small refactorings of BPF program call sites Toke Høiland-Jørgensen
2022-09-05 19:33 ` Toke Høiland-Jørgensen [this message]
2022-09-06 21:58 ` [PATCH bpf-next v2 1/3] dev: Move received_rps counter next to RPS members in softnet data Song Liu
2022-09-05 19:33 ` [PATCH bpf-next v2 2/3] bpf: Expand map key argument of bpf_redirect_map to u64 Toke Høiland-Jørgensen
2022-09-06 22:02 ` Song Liu
2022-09-05 19:33 ` [PATCH bpf-next v2 3/3] bpf: Use 64-bit return value for bpf_prog_run Toke Høiland-Jørgensen
2022-09-06 22:07 ` Song Liu
2022-09-16 20:47 ` [PATCH bpf-next v2 0/3] A couple of small refactorings of BPF program call sites Daniel Borkmann
2022-09-16 20:59 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905193359.969347-2-toke@redhat.com \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox