Re: [PATCH bpf-next] bpf: Prevent bpf program recursion for raw tracepoint probes

[kernel test robot <lkp@intel.com>]

Hi Jiri,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiri-Olsa/bpf-Prevent-bpf-program-recursion-for-raw-tracepoint-probes/20220908-194832
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm64-buildonly-randconfig-r002-20220907 (https://download.01.org/0day-ci/archive/20220909/202209091236.avgRKOSj-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f68b567cfb6572c20e431242a440cc5f01452485
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jiri-Olsa/bpf-Prevent-bpf-program-recursion-for-raw-tracepoint-probes/20220908-194832
        git checkout f68b567cfb6572c20e431242a440cc5f01452485
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   aarch64-linux-ld: Unexpected GOT/PLT entries detected!
   aarch64-linux-ld: Unexpected run-time procedure linkages detected!
   aarch64-linux-ld: kernel/trace/bpf_trace.o: in function `__bpf_trace_run':
>> kernel/trace/bpf_trace.c:2046: undefined reference to `bpf_prog_inc_misses_counter'
>> aarch64-linux-ld: kernel/trace/bpf_trace.c:2046: undefined reference to `bpf_prog_inc_misses_counter'
>> aarch64-linux-ld: kernel/trace/bpf_trace.c:2046: undefined reference to `bpf_prog_inc_misses_counter'
>> aarch64-linux-ld: kernel/trace/bpf_trace.c:2046: undefined reference to `bpf_prog_inc_misses_counter'
>> aarch64-linux-ld: kernel/trace/bpf_trace.c:2046: undefined reference to `bpf_prog_inc_misses_counter'
   aarch64-linux-ld: kernel/trace/bpf_trace.o:kernel/trace/bpf_trace.c:2046: more undefined references to `bpf_prog_inc_misses_counter' follow


vim +2046 kernel/trace/bpf_trace.c

  2040	
  2041	static __always_inline
  2042	void __bpf_trace_run(struct bpf_prog *prog, u64 *args)
  2043	{
  2044		cant_sleep();
  2045		if (unlikely(this_cpu_inc_return(*(prog->active)) != 1)) {
> 2046			bpf_prog_inc_misses_counter(prog);
  2047			goto out;
  2048		}
  2049		rcu_read_lock();
  2050		(void) bpf_prog_run(prog, args);
  2051		rcu_read_unlock();
  2052	out:
  2053		this_cpu_dec(*(prog->active));
  2054	}
  2055	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp