From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, martin.lau@kernel.org,
andrii@kernel.org, ast@kernel.org, Kernel-team@fb.com,
Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [PATCH bpf-next v1 5/8] bpf: Add bpf_dynptr_clone
Date: Sat, 10 Sep 2022 08:31:18 +0300 [thread overview]
Message-ID: <20220910083118.6591eca8@blondie> (raw)
In-Reply-To: <CAJnrk1a53F=LLaU+gdmXGcZBBeUR-anALT3iO6pyHKiZpD0cNw@mail.gmail.com>
On Fri, 9 Sep 2022 15:18:57 -0700 Joanne Koong <joannelkoong@gmail.com> wrote:
> I like the idea, where 'off' is an offset from ptr's offset and 'len'
> is the number of bytes to trim.
Actually parameters better be 'from' (inclusive) and 'to' (exclusive),
similar to slicing in most languages. Specifying a negative 'to' provides
the trimming functionality.
> Btw, I will be traveling for the next ~6 weeks and won't have access
> to a computer, so v2 will be sometime after that.
Enjoy
next prev parent reply other threads:[~2022-09-10 5:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 0:02 [PATCH bpf-next v1 0/8] Dynptr convenience helpers Joanne Koong
2022-09-08 0:02 ` [PATCH bpf-next v1 1/8] bpf: Add bpf_dynptr_data_rdonly Joanne Koong
2022-09-09 15:29 ` Song Liu
2022-09-09 15:32 ` Alexei Starovoitov
2022-09-09 15:59 ` Song Liu
2022-09-09 15:51 ` Shmulik Ladkani
2022-09-08 0:02 ` [PATCH bpf-next v1 2/8] bpf: Add bpf_dynptr_trim and bpf_dynptr_advance Joanne Koong
2022-09-09 15:32 ` Song Liu
2022-09-09 16:16 ` Shmulik Ladkani
2022-09-28 22:14 ` Andrii Nakryiko
2022-09-08 0:02 ` [PATCH bpf-next v1 3/8] bpf: Add bpf_dynptr_is_null and bpf_dynptr_is_rdonly Joanne Koong
2022-09-09 15:46 ` Song Liu
2022-09-09 21:28 ` Joanne Koong
2022-09-09 23:17 ` Song Liu
2022-09-08 0:02 ` [PATCH bpf-next v1 4/8] bpf: Add bpf_dynptr_get_size and bpf_dynptr_get_offset Joanne Koong
2022-09-09 16:52 ` Shmulik Ladkani
2022-09-09 20:37 ` Joanne Koong
2022-09-08 0:02 ` [PATCH bpf-next v1 5/8] bpf: Add bpf_dynptr_clone Joanne Koong
2022-09-09 16:41 ` Shmulik Ladkani
2022-09-09 22:18 ` Joanne Koong
2022-09-10 5:31 ` Shmulik Ladkani [this message]
2022-09-28 22:34 ` Andrii Nakryiko
2022-09-28 22:29 ` Andrii Nakryiko
2022-09-08 0:02 ` [PATCH bpf-next v1 6/8] bpf: Add verifier support for custom callback return range Joanne Koong
2022-09-08 0:02 ` [PATCH bpf-next v1 7/8] bpf: Add bpf_dynptr_iterator Joanne Koong
2022-09-19 0:07 ` Kumar Kartikeya Dwivedi
2022-09-28 22:47 ` Andrii Nakryiko
2022-09-28 22:41 ` Andrii Nakryiko
2022-09-29 0:31 ` Kumar Kartikeya Dwivedi
2022-09-29 0:43 ` Andrii Nakryiko
2022-10-02 16:45 ` Kumar Kartikeya Dwivedi
2022-10-03 18:39 ` Andrii Nakryiko
2022-09-08 0:02 ` [PATCH bpf-next v1 8/8] selftests/bpf: Tests for dynptr convenience helpers Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220910083118.6591eca8@blondie \
--to=shmulik.ladkani@gmail.com \
--cc=Kernel-team@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eyal.birger@gmail.com \
--cc=joannelkoong@gmail.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox