BPF List
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hou Tao <houtao@huaweicloud.com>,
	bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>
Cc: kbuild-all@lists.01.org, Song Liu <songliubraving@fb.com>,
	Hao Luo <haoluo@google.com>, Yonghong Song <yhs@fb.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, KP Singh <kpsingh@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Jiri Olsa <jolsa@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Lorenz Bauer <oss@lmb.io>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	houtao1@huawei.com
Subject: Re: [PATCH bpf-next 03/10] bpf: Support bpf_dynptr-typed map key for bpf syscall
Date: Sun, 18 Sep 2022 02:29:44 +0800	[thread overview]
Message-ID: <202209180207.PvS9ya46-lkp@intel.com> (raw)
In-Reply-To: <20220917153125.2001645-4-houtao@huaweicloud.com>

Hi Hou,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Hou-Tao/Add-support-for-qp-trie-map/20220917-231450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-r002-20220917 (https://download.01.org/0day-ci/archive/20220918/202209180207.PvS9ya46-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1995ae6874ef9089b4eee12c00ba9c5af264b8bc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hou-Tao/Add-support-for-qp-trie-map/20220917-231450
        git checkout 1995ae6874ef9089b4eee12c00ba9c5af264b8bc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: kernel/bpf/syscall.o: in function `bpf_copy_to_dynptr_ukey':
>> kernel/bpf/syscall.c:1368: undefined reference to `__get_user_bad'
   pahole: .tmp_vmlinux.btf: No such file or directory
   .btf.vmlinux.bin.o: file not recognized: file format not recognized


vim +1368 kernel/bpf/syscall.c

  1361	
  1362	static int bpf_copy_to_dynptr_ukey(struct bpf_dynptr_user __user *uptr,
  1363					   struct bpf_dynptr_kern *kptr)
  1364	{
  1365		unsigned int size;
  1366		u64 udata;
  1367	
> 1368		if (get_user(udata, &uptr->data))
  1369			return -EFAULT;
  1370	
  1371		/* Also zeroing the reserved field in uptr */
  1372		size = bpf_dynptr_get_size(kptr);
  1373		if (copy_to_user(u64_to_user_ptr(udata), kptr->data + kptr->offset, size) ||
  1374		    put_user(size, &uptr->size) || put_user(0, &uptr->size + 1))
  1375			return -EFAULT;
  1376	
  1377		return 0;
  1378	}
  1379	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  parent reply	other threads:[~2022-09-17 18:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 15:31 [PATCH bpf-next 00/10] Add support for qp-trie map Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 01/10] bpf: Export bpf_dynptr_{get|set}_size Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 02/10] bpf: Add helper btf_type_is_bpf_dynptr() Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 03/10] bpf: Support bpf_dynptr-typed map key for bpf syscall Hou Tao
2022-09-17 18:18   ` kernel test robot
2022-09-17 18:29   ` kernel test robot [this message]
2022-09-17 15:31 ` [PATCH bpf-next 04/10] bpf: Support bpf_dynptr-typed map key for bpf program Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 05/10] libbpf: Add helpers for bpf_dynptr_user Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 06/10] bpf: Add support for qp-trie map Hou Tao
2024-06-05 13:48   ` qp-trie? " Alexei Starovoitov
2024-06-06  1:41     ` Hou Tao
2024-06-06  3:45       ` Alexei Starovoitov
2024-06-06  4:31         ` Hou Tao
2024-06-06  5:36           ` Alexei Starovoitov
2022-09-17 15:31 ` [PATCH bpf-next 07/10] selftests/bpf: Add two new dynptr_fail cases for map key Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 08/10] selftests/bpf: Add test case for basic qp-trie map operations Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 09/10] selftests/bpf: Add benchmark for qp-trie map Hou Tao
2022-09-17 15:31 ` [PATCH bpf-next 10/10] selftests/bpf: Add tests for qp-trie map by using bpf syscalls Hou Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202209180207.PvS9ya46-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=haoluo@google.com \
    --cc=houtao1@huawei.com \
    --cc=houtao@huaweicloud.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=oss@lmb.io \
    --cc=paulmck@kernel.org \
    --cc=sdf@google.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox