From: Li Zhong <floridsleeves@gmail.com>
To: linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Cc: namhyung@kernel.org, jolsa@kernel.org,
alexander.shishkin@linux.intel.com, mark.rutland@arm.com,
acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
lily <floridsleeves@gmail.com>
Subject: [PATCH v2] kernel/events/core: check return value of task_function_call()
Date: Mon, 19 Sep 2022 12:16:11 -0700 [thread overview]
Message-ID: <20220919191611.1589661-1-floridsleeves@gmail.com> (raw)
From: lily <floridsleeves@gmail.com>
Check the return value of task_function_call(), which could be error
code when the execution fails. We log this on info level.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
kernel/events/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 2621fd24ad26..3848631b009c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -13520,7 +13520,10 @@ static void perf_cgroup_attach(struct cgroup_taskset *tset)
struct cgroup_subsys_state *css;
cgroup_taskset_for_each(task, css, tset)
- task_function_call(task, __perf_cgroup_move, task);
+ if (!task_function_call(task, __perf_cgroup_move, task)) {
+ printk(KERN_INFO "perf: this process isn't running!\n");
+ continue;
+ }
}
struct cgroup_subsys perf_event_cgrp_subsys = {
--
2.25.1
next reply other threads:[~2022-09-19 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 19:16 Li Zhong [this message]
2022-09-21 7:46 ` [PATCH v2] kernel/events/core: check return value of task_function_call() Ingo Molnar
2022-09-21 8:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919191611.1589661-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox