From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8E0C32771 for ; Mon, 26 Sep 2022 16:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiIZQp3 (ORCPT ); Mon, 26 Sep 2022 12:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiIZQpF (ORCPT ); Mon, 26 Sep 2022 12:45:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C01125C55 for ; Mon, 26 Sep 2022 08:33:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CC7960F7C for ; Mon, 26 Sep 2022 15:33:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04963C433D7; Mon, 26 Sep 2022 15:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664206425; bh=Qsg9RaIVaH/6PKwm5nMtfB6tMZ1hKYKCAi1eOZVa4iY=; h=From:To:Cc:Subject:Date:From; b=CsjLb67WdYnyiA72E2t+OW8gpA0PMTdg6VOa27ADVCWoaXUGmKfthDP6rQ0bJrxbo vvXaB0ZYEOuVRQcXi+tshoFlPX/2/5xE05OUGCQu+93NxLel7J4Pb+IWU/4KmLWbSi DFhzjDBfVlxKRvivATCDqOpUSerA/sJTJxnY06Gc7tSJzkcn+uO+nltJyzMd/1ixQV SM+zHINVoKBHOx+s2LXeakEVoGrF1ocHynXiGxcjywnIsO/0EyyLHnZankFqST00dP TUTPrp74Z9m49H97vvxIXKBsoaAa7NnmFkYIHb8IidfCfhP2nwIF7zIRmOLVR/8YuH BUKJmzEUsSRQg== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , "Masami Hiramatsu (Google)" , Peter Zijlstra , Martynas Pumputis Subject: [PATCHv5 bpf-next 0/6] bpf: Fixes for CONFIG_X86_KERNEL_IBT Date: Mon, 26 Sep 2022 17:33:34 +0200 Message-Id: <20220926153340.1621984-1-jolsa@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org hi, Martynas reported bpf_get_func_ip returning +4 address when CONFIG_X86_KERNEL_IBT option is enabled and I found there are some failing bpf tests when this option is enabled. The CONFIG_X86_KERNEL_IBT option adds endbr instruction at the function entry, so the idea is to 'fix' entry ip for kprobe_multi and trampoline probes, because they are placed on the function entry. v5 changes: - updated uapi/linux/bpf.h headers with comment for bpf_get_func_ip returning 0 [Andrii] - added acks v4 changes: - used get_kernel_nofault to read previous instruction [Peter] - used movabs instruction in trampoline comment [Peter] - renamed fentry_ip argument in kprobe_multi_link_handler [Peter] v3 changes: - using 'unused' bpf function to get IBT config option into selftest skeleton - rebased to current bpf-next/master - added ack/review from Masami v2 changes: - change kprobes get_func_ip to return zero for kprobes attached within the function body [Andrii] - detect IBT config and properly test kprobe with offset [Andrii] v1 changes: - read previous instruction in kprobe_multi link handler and adjust entry_ip for CONFIG_X86_KERNEL_IBT option - split first patch into 2 separate changes - update changelogs thanks, jirka --- Jiri Olsa (6): kprobes: Add new KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag ftrace: Keep the resolved addr in kallsyms_callback bpf: Use given function address for trampoline ip arg bpf: Adjust kprobe_multi entry_ip for CONFIG_X86_KERNEL_IBT bpf: Return value in kprobe get_func_ip only for entry address selftests/bpf: Fix get_func_ip offset test for CONFIG_X86_KERNEL_IBT arch/x86/net/bpf_jit_comp.c | 11 +++++------ include/linux/kprobes.h | 1 + include/uapi/linux/bpf.h | 1 + kernel/kprobes.c | 6 +++++- kernel/trace/bpf_trace.c | 25 ++++++++++++++++++++++--- kernel/trace/ftrace.c | 3 +-- tools/include/uapi/linux/bpf.h | 1 + tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++----------- tools/testing/selftests/bpf/progs/get_func_ip_test.c | 25 +++++++++++++------------ tools/testing/selftests/bpf/progs/kprobe_multi.c | 4 +--- 10 files changed, 98 insertions(+), 38 deletions(-)