From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
KP Singh <kpsingh@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Tejun Heo <tj@kernel.org>
Subject: [PATCH bpf-next 0/5] bpf: Implement cgroup local storage available to non-cgroup-attached bpf progs
Date: Thu, 13 Oct 2022 21:56:19 -0700 [thread overview]
Message-ID: <20221014045619.3309899-1-yhs@fb.com> (raw)
There already exists a local storage implementation for cgroup-attached
bpf programs. See map type BPF_MAP_TYPE_CGROUP_STORAGE and helper
bpf_get_local_storage(). But there are use cases such that non-cgroup
attached bpf progs wants to access cgroup local storage data. For example,
tc egress prog has access to sk and cgroup. It is possible to use
sk local storage to emulate cgroup local storage by storing data in socket.
But this is a waste as it could be lots of sockets belonging to a particular
cgroup. Alternatively, a separate map can be created with cgroup id as the key.
But this will introduce additional overhead to manipulate the new map.
A cgroup local storage, similar to existing sk/inode/task storage,
should help for this use case.
This patch implemented new cgroup local storage available to
non-cgroup-attached bpf programs. In the patch series, Patch 1
is a preparation patch. Patch 2 implemented new cgroup local storage
kernel support. Patches 3 and 4 implemented libbpf and bpftool support.
Patch 5 added two tests to validate kernel/libbpf implementations.
Yonghong Song (5):
bpf: Make struct cgroup btf id global
bpf: Implement cgroup storage available to non-cgroup-attached bpf
progs
libbpf: Support new cgroup local storage
bpftool: Support new cgroup local storage
selftests/bpf: Add selftests for cgroup local storage
include/linux/bpf.h | 3 +
include/linux/bpf_types.h | 1 +
include/linux/btf_ids.h | 1 +
include/linux/cgroup-defs.h | 4 +
include/uapi/linux/bpf.h | 39 +++
kernel/bpf/Makefile | 2 +-
kernel/bpf/bpf_cgroup_storage.c | 280 ++++++++++++++++++
kernel/bpf/cgroup_iter.c | 2 +-
kernel/bpf/helpers.c | 6 +
kernel/bpf/syscall.c | 3 +-
kernel/bpf/verifier.c | 14 +-
kernel/cgroup/cgroup.c | 4 +
kernel/trace/bpf_trace.c | 4 +
scripts/bpf_doc.py | 2 +
.../bpf/bpftool/Documentation/bpftool-map.rst | 2 +-
tools/bpf/bpftool/map.c | 2 +-
tools/include/uapi/linux/bpf.h | 39 +++
tools/lib/bpf/libbpf.c | 1 +
tools/lib/bpf/libbpf_probes.c | 1 +
.../bpf/prog_tests/cgroup_local_storage.c | 92 ++++++
.../bpf/progs/cgroup_local_storage.c | 88 ++++++
.../selftests/bpf/progs/cgroup_ls_recursion.c | 70 +++++
22 files changed, 654 insertions(+), 6 deletions(-)
create mode 100644 kernel/bpf/bpf_cgroup_storage.c
create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_local_storage.c
create mode 100644 tools/testing/selftests/bpf/progs/cgroup_local_storage.c
create mode 100644 tools/testing/selftests/bpf/progs/cgroup_ls_recursion.c
--
2.30.2
next reply other threads:[~2022-10-14 4:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 4:56 Yonghong Song [this message]
2022-10-14 4:56 ` [PATCH bpf-next 1/5] bpf: Make struct cgroup btf id global Yonghong Song
2022-10-14 4:56 ` [PATCH bpf-next 2/5] bpf: Implement cgroup storage available to non-cgroup-attached bpf progs Yonghong Song
2022-10-17 18:01 ` sdf
2022-10-17 18:25 ` Yosry Ahmed
2022-10-17 18:43 ` Stanislav Fomichev
2022-10-17 18:47 ` Yosry Ahmed
2022-10-17 19:07 ` Stanislav Fomichev
2022-10-17 19:11 ` Yosry Ahmed
2022-10-17 19:26 ` Tejun Heo
2022-10-17 21:07 ` Martin KaFai Lau
2022-10-17 21:23 ` Yosry Ahmed
2022-10-17 23:55 ` Martin KaFai Lau
2022-10-18 0:47 ` Yosry Ahmed
2022-10-17 22:16 ` sdf
2022-10-18 0:52 ` Martin KaFai Lau
2022-10-18 5:59 ` Yonghong Song
2022-10-18 17:08 ` sdf
2022-10-18 17:17 ` Alexei Starovoitov
2022-10-18 18:08 ` Martin KaFai Lau
2022-10-18 18:11 ` Yosry Ahmed
2022-10-18 18:26 ` Yonghong Song
2022-10-18 23:12 ` Andrii Nakryiko
2022-10-17 20:15 ` Yonghong Song
2022-10-17 20:18 ` Yosry Ahmed
2022-10-17 20:13 ` Yonghong Song
2022-10-17 20:10 ` Yonghong Song
2022-10-17 20:14 ` Yosry Ahmed
2022-10-17 20:29 ` Yonghong Song
2022-10-17 19:23 ` Yonghong Song
2022-10-17 21:03 ` Stanislav Fomichev
2022-10-17 22:26 ` Martin KaFai Lau
2022-10-17 18:16 ` David Vernet
2022-10-17 19:45 ` Yonghong Song
2022-10-14 4:56 ` [PATCH bpf-next 3/5] libbpf: Support new cgroup local storage Yonghong Song
2022-10-14 4:56 ` [PATCH bpf-next 4/5] bpftool: " Yonghong Song
2022-10-17 10:26 ` Quentin Monnet
2022-10-14 4:56 ` [PATCH bpf-next 5/5] selftests/bpf: Add selftests for " Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014045619.3309899-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox