Re: [PATCH bpf-next v2 2/6] bpf: Implement cgroup storage available to non-cgroup-attached bpf progs

David Vernet
2022-10-21T05:26:17Z

On Fri, Oct 21, 2022 at 12:22:49AM -0500, David Vernet wrote:
> > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> > index 49fb9ec8366d..0ddf0834b1b8 100644
> > --- a/kernel/trace/bpf_trace.c
> > +++ b/kernel/trace/bpf_trace.c
> > @@ -1454,6 +1454,10 @@ bpf_tracing_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
> > return &bpf_get_current_cgroup_id_proto;
> > case BPF_FUNC_get_current_ancestor_cgroup_id:
> > return &bpf_get_current_ancestor_cgroup_id_proto;
> > + case BPF_FUNC_cgrp_storage_get:
> > + return &bpf_cgrp_storage_get_proto;
> > + case BPF_FUNC_cgrp_storage_delete:
> > + return &bpf_cgrp_storage_delete_proto;
>
> Why the #ifdef CONFIG_CGROUPS check in bpf_base_func_proto(), but not
> here?

Sorry, just realized it's already in an #ifdef CONFIG_CGROUPS block.