BPF List
 help / color / mirror / Atom feed
From: Jonas Rabenstein <rabenstein@cs.fau.de>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Jonas Rabenstein <rabenstein@cs.fau.de>,
	Song Liu <song@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] bpf: mark get_entry_ip as __maybe_unused
Date: Thu,  3 Nov 2022 16:03:03 +0100	[thread overview]
Message-ID: <20221103150303.974028-1-rabenstein@cs.fau.de> (raw)

Commit c09eb2e578eb1668bbc ("bpf: Adjust kprobe_multi entry_ip
for CONFIG_X86_KERNEL_IBT") introduced the get_entry_ip() function.
Depending on CONFIG_X86_KERNEL_IBT it is a static function or only
a macro definition. The only user of this symbol so far is in
kprobe_multi_link_handler() if CONFIG_FPROBE is enabled.
If CONFIG_FROBE is not set, the symbol is not used and - depending
on CONFIG_X86_KERNEL_IBT - a warning for get_entry_ip() is emitted.
To solve this, the function should be marked as __maybe_unused.

Signed-off-by: Jonas Rabenstein <rabenstein@cs.fau.de>
---
 kernel/trace/bpf_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index f2d8d070d024..19131aae0bc3 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -1032,7 +1032,7 @@ static const struct bpf_func_proto bpf_get_func_ip_proto_tracing = {
 };
 
 #ifdef CONFIG_X86_KERNEL_IBT
-static unsigned long get_entry_ip(unsigned long fentry_ip)
+static unsigned long __maybe_unused get_entry_ip(unsigned long fentry_ip)
 {
 	u32 instr;
 
-- 
2.37.4


             reply	other threads:[~2022-11-03 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:03 Jonas Rabenstein [this message]
2022-11-03 15:32 ` [PATCH] bpf: mark get_entry_ip as __maybe_unused Jonas Rabenstein
2022-11-04 23:03   ` Daniel Borkmann
2022-11-07  8:56   ` Greg KH
2022-11-07  9:29     ` Greg KH
2022-11-07  9:48       ` Jonas Rabenstein
2022-11-07  9:51         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103150303.974028-1-rabenstein@cs.fau.de \
    --to=rabenstein@cs.fau.de \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox