From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: [PATCH RFC bpf-next v1 0/2] Fix deadlock with bpf_timer in fentry/fexit progs
Date: Sun, 6 Nov 2022 07:21:50 +0530 [thread overview]
Message-ID: <20221106015152.2556188-1-memxor@gmail.com> (raw)
Hi, this is a fix for a deadlock condition I noticed (and verified by
constructing a test case, see patch #2) while looking at the code. There
might be alternative ways to solve this, like having percpu map ops
recursion counter, and detecting reentrancy based on that. I went for
the simpler option for now.
Previous discussions on a patch doing something similar for a different
issue here, but never added BPF_PROG_TYPE_TRACING to this list:
https://lore.kernel.org/bpf/CALOAHbBK1=ujbZp5n4t9zQf+DPZ3-a2ZDL0a3sfhVU6meJGqYw@mail.gmail.com
https://lore.kernel.org/bpf/CALOAHbAQ7AKNPrkawGKHarkB5CGkWXTC8P=+EJP3DAPNEf=Ayw@mail.gmail.com
Note that timer and timer_crash selftests are broken by this change, so
it has potential for wider breakage.
Kumar Kartikeya Dwivedi (2):
bpf: Fix deadlock for bpf_timer's spinlock
[EXAMPLE] selftests/bpf: Add timer deadlock example
kernel/bpf/verifier.c | 10 ++--
.../testing/selftests/bpf/prog_tests/timer.c | 21 +++++---
.../selftests/bpf/prog_tests/timer_crash.c | 9 +++-
.../selftests/bpf/prog_tests/timer_deadlock.c | 29 +++++++++++
tools/testing/selftests/bpf/progs/timer.c | 8 +--
.../testing/selftests/bpf/progs/timer_crash.c | 4 +-
.../selftests/bpf/progs/timer_deadlock.c | 50 +++++++++++++++++++
7 files changed, 113 insertions(+), 18 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/timer_deadlock.c
create mode 100644 tools/testing/selftests/bpf/progs/timer_deadlock.c
base-commit: 25906092edb4bcf94cb669bd1ed03a0ef2f4120c
--
2.38.1
next reply other threads:[~2022-11-06 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 1:51 Kumar Kartikeya Dwivedi [this message]
2022-11-06 1:51 ` [PATCH RFC bpf-next v1 1/2] bpf: Fix deadlock for bpf_timer's spinlock Kumar Kartikeya Dwivedi
2022-11-06 21:20 ` Alexei Starovoitov
2022-11-06 21:44 ` Kumar Kartikeya Dwivedi
2022-11-07 0:31 ` Alexei Starovoitov
2022-11-07 1:48 ` Kumar Kartikeya Dwivedi
2022-11-07 2:34 ` Alexei Starovoitov
2022-11-07 3:45 ` Alexei Starovoitov
2022-11-07 23:13 ` Kumar Kartikeya Dwivedi
2022-11-06 1:51 ` [PATCH RFC bpf-next v1 2/2] [EXAMPLE] selftests/bpf: Add timer deadlock example Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106015152.2556188-1-memxor@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox