From: Jakub Kicinski <kuba@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <grygorii.strashko@ti.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <chi.minghao@zte.com.cn>,
<mkl@pengutronix.de>, <wsa+renesas@sang-engineering.com>,
<ardb@kernel.org>, <yangyingliang@huawei.com>,
<mugunthanvnm@ti.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net] net: cpsw: disable napi in cpsw_ndo_open()
Date: Wed, 9 Nov 2022 18:31:47 -0800 [thread overview]
Message-ID: <20221109183147.17dba3ef@kernel.org> (raw)
In-Reply-To: <20221109011537.96975-1-shaozhengchao@huawei.com>
On Wed, 9 Nov 2022 09:15:37 +0800 Zhengchao Shao wrote:
> When failed to create xdp rxqs or fill rx channels in cpsw_ndo_open() for
> opening device, napi isn't disabled. When open cpsw device next time, it
> will report a invalid opcode issue. Fix it. Only be compiled, not be
> tested.
>
> Fixes: d354eb85d618 ("drivers: net: cpsw: dual_emac: simplify napi usage")
Nice work, not a trivial Fixes tag to zero in on, I appreciate
the improvement :)
next prev parent reply other threads:[~2022-11-10 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 1:15 [PATCH net] net: cpsw: disable napi in cpsw_ndo_open() Zhengchao Shao
2022-11-10 2:31 ` Jakub Kicinski [this message]
2022-11-10 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109183147.17dba3ef@kernel.org \
--to=kuba@kernel.org \
--cc=ardb@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chi.minghao@zte.com.cn \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangyingliang@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox