BPF List
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: linux-next: manual merge of the bpf-next tree with the perf tree
Date: Fri, 11 Nov 2022 10:40:09 +1100	[thread overview]
Message-ID: <20221111104009.0edfa8a6@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1923 bytes --]

Hi all,

Today's linux-next merge of the bpf-next tree got a conflict in:

  tools/perf/util/stat.c

between commit:

  8b76a3188b85 ("perf stat: Remove unused perf_counts.aggr field")

from the perf tree and commit:

  c302378bc157 ("libbpf: Hashmap interface update to allow both long and void* keys/values")

from the bpf-next tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc tools/perf/util/stat.c
index 3a432a949d46,c0656f85bfa5..000000000000
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@@ -318,7 -258,27 +318,7 @@@ void evlist__copy_prev_raw_counts(struc
  		evsel__copy_prev_raw_counts(evsel);
  }
  
- static size_t pkg_id_hash(const void *__key, void *ctx __maybe_unused)
 -void evlist__save_aggr_prev_raw_counts(struct evlist *evlist)
 -{
 -	struct evsel *evsel;
 -
 -	/*
 -	 * To collect the overall statistics for interval mode,
 -	 * we copy the counts from evsel->prev_raw_counts to
 -	 * evsel->counts. The perf_stat_process_counter creates
 -	 * aggr values from per cpu values, but the per cpu values
 -	 * are 0 for AGGR_GLOBAL. So we use a trick that saves the
 -	 * previous aggr value to the first member of perf_counts,
 -	 * then aggr calculation in process_counter_values can work
 -	 * correctly.
 -	 */
 -	evlist__for_each_entry(evlist, evsel) {
 -		*perf_counts(evsel->prev_raw_counts, 0, 0) =
 -			evsel->prev_raw_counts->aggr;
 -	}
 -}
 -
+ static size_t pkg_id_hash(long __key, void *ctx __maybe_unused)
  {
  	uint64_t *key = (uint64_t *) __key;
  

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-11-10 23:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 23:40 Stephen Rothwell [this message]
2022-11-14  1:16 ` linux-next: manual merge of the bpf-next tree with the perf tree Stephen Rothwell
2022-12-14 21:43   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221111104009.0edfa8a6@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=acme@redhat.com \
    --cc=andrii@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox