From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96C4C4332F for ; Fri, 11 Nov 2022 14:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232985AbiKKOeW (ORCPT ); Fri, 11 Nov 2022 09:34:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234609AbiKKOeP (ORCPT ); Fri, 11 Nov 2022 09:34:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB6956EFD for ; Fri, 11 Nov 2022 06:34:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C524B823F8 for ; Fri, 11 Nov 2022 14:34:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1638BC433C1; Fri, 11 Nov 2022 14:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668177247; bh=7wovpbCN6iri8bpiqnWAMrbiiRxRb+uXy0ogxgWGH3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+CHDzd4hzyaSJp76ESS77/8ANRxIFAbqcWo0OaghvS7S7Nm9YhAzweoaC+0lYxC3 MHkKHwe6ttq7U22XBKVXk1k2N9f0WlrDwtoQmJVz08iRz1kuicyhdGhCqSu8AprOZl Krx4HDdBhClxd8nJKO+fPWmyr3dy1jTpE1xXsxXvpmSg9rJhk+Xyul7oycSuXmO9zM 9kPWsTzqIe3iaKK6ClkvXPntIiStZBg0Xyf+FJnRU2FTqNZ3wZWSOtVKtH09lsBxKa tLrPijsy2OQQYfGTFmVquBAEOP9QhGPrL/INqIsVYtsP40T7WzEqtKNK++9R9T7A7F BseK8dtlVHvdg== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo Subject: [PATCHv2 bpf-next 2/2] selftests/bpf: Add bpf_vma_build_id_parse kfunc test Date: Fri, 11 Nov 2022 15:33:41 +0100 Message-Id: <20221111143341.508022-3-jolsa@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221111143341.508022-1-jolsa@kernel.org> References: <20221111143341.508022-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Adding test for bpf_vma_build_id_parse kfunc. On bpf side the test finds the vma of the test_progs text through the test function pointer and reads its build id with the new kfunc. On user side the test uses readelf to get test_progs build id and compares it with the one from bpf side. Signed-off-by: Jiri Olsa --- .../bpf/prog_tests/bpf_vma_build_id_parse.c | 88 +++++++++++++++++++ .../bpf/progs/bpf_vma_build_id_parse.c | 40 +++++++++ 2 files changed, 128 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/bpf_vma_build_id_parse.c create mode 100644 tools/testing/selftests/bpf/progs/bpf_vma_build_id_parse.c diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_vma_build_id_parse.c b/tools/testing/selftests/bpf/prog_tests/bpf_vma_build_id_parse.c new file mode 100644 index 000000000000..83030a3b2c42 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/bpf_vma_build_id_parse.c @@ -0,0 +1,88 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include +#include +#include "bpf_vma_build_id_parse.skel.h" + +#define BUILDID_STR_SIZE (BPF_BUILD_ID_SIZE*2 + 1) + +static int read_buildid(char **build_id) +{ + char tmp[] = "/tmp/dataXXXXXX"; + char buf[200]; + int err, fd; + FILE *f; + + fd = mkstemp(tmp); + if (fd == -1) + return -1; + close(fd); + + snprintf(buf, sizeof(buf), + "readelf -n ./test_progs 2>/dev/null | grep 'Build ID' | awk '{print $3}' > %s", + tmp); + + err = system(buf); + if (err) + goto out; + + f = fopen(tmp, "r"); + if (f) { + if (fscanf(f, "%ms$*\n", build_id) != 1) { + *build_id = NULL; + err = -1; + } + fclose(f); + } + +out: + unlink(tmp); + return err; +} + +void test_bpf_vma_build_id_parse(void) +{ + char bpf_build_id[BUILDID_STR_SIZE] = {}, *build_id; + LIBBPF_OPTS(bpf_test_run_opts, topts); + struct bpf_vma_build_id_parse *skel; + int i, err, prog_fd; + + skel = bpf_vma_build_id_parse__open_and_load(); + if (!ASSERT_OK_PTR(skel, "bpf_vma_build_id_parse__open_and_load")) + return; + + skel->bss->target_pid = getpid(); + skel->bss->addr = (__u64)(uintptr_t)test_bpf_vma_build_id_parse; + + err = bpf_vma_build_id_parse__attach(skel); + if (!ASSERT_OK(err, "bpf_vma_build_id_parse__attach")) + goto out; + + prog_fd = bpf_program__fd(skel->progs.test1); + err = bpf_prog_test_run_opts(prog_fd, &topts); + ASSERT_OK(err, "test_run_err"); + ASSERT_EQ(topts.retval, 0, "test_run_retval"); + + ASSERT_EQ(skel->data->ret, 0, "ret"); + + ASSERT_GT(skel->data->size_pass, 0, "size_pass"); + ASSERT_EQ(skel->data->size_fail, -EINVAL, "size_fail"); + + /* Read build id via readelf to compare with build_id. */ + if (!ASSERT_OK(read_buildid(&build_id), "read_buildid")) + goto out; + + ASSERT_EQ(skel->data->size_pass, strlen(build_id)/2, "build_id_size"); + + /* Convert bpf build id to string, so we can compare it later. */ + for (i = 0; i < skel->data->size_pass; i++) { + sprintf(bpf_build_id + i*2, "%02x", + (unsigned char) skel->bss->build_id[i]); + } + ASSERT_STREQ(bpf_build_id, build_id, "build_id_match"); + + free(build_id); +out: + bpf_vma_build_id_parse__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/bpf_vma_build_id_parse.c b/tools/testing/selftests/bpf/progs/bpf_vma_build_id_parse.c new file mode 100644 index 000000000000..8937212207db --- /dev/null +++ b/tools/testing/selftests/bpf/progs/bpf_vma_build_id_parse.c @@ -0,0 +1,40 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "vmlinux.h" +#include +#include + +char _license[] SEC("license") = "GPL"; + +#define BPF_BUILD_ID_SIZE 20 + +extern int bpf_vma_build_id_parse(struct vm_area_struct *vma, unsigned char *build_id, + size_t build_id__sz) __ksym; + +pid_t target_pid = 0; +__u64 addr = 0; + +int ret = -1; +int size_pass = -1; +int size_fail = -1; + +unsigned char build_id[BPF_BUILD_ID_SIZE]; + +static long check_vma(struct task_struct *task, struct vm_area_struct *vma, + void *data) +{ + size_fail = bpf_vma_build_id_parse(vma, build_id, sizeof(build_id)/2); + size_pass = bpf_vma_build_id_parse(vma, build_id, sizeof(build_id)); + return 0; +} + +SEC("fentry/bpf_fentry_test1") +int BPF_PROG(test1, int a) +{ + struct task_struct *task = bpf_get_current_task_btf(); + + if (task->pid != target_pid) + return 0; + + ret = bpf_find_vma(task, addr, check_vma, NULL, 0); + return 0; +} -- 2.38.1