From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
bpf@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
Dave Marchevsky <davemarchevsky@meta.com>,
Delyan Kratunov <delyank@meta.com>
Subject: Re: [PATCH bpf-next v6 11/26] bpf: Allow locking bpf_spin_lock in allocated objects
Date: Mon, 14 Nov 2022 11:25:01 +0300 [thread overview]
Message-ID: <202211140520.Q5kvXPSL-lkp@intel.com> (raw)
In-Reply-To: <20221111193224.876706-12-memxor@gmail.com>
Hi Kumar,
url: https://github.com/intel-lab-lkp/linux/commits/Kumar-Kartikeya-Dwivedi/Allocated-objects-BPF-linked-lists/20221112-033643
base: e5659e4e19e49f1eac58bb07ce8bc2d78a89fe65
patch link: https://lore.kernel.org/r/20221111193224.876706-12-memxor%40gmail.com
patch subject: [PATCH bpf-next v6 11/26] bpf: Allow locking bpf_spin_lock in allocated objects
config: x86_64-randconfig-m001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
kernel/bpf/verifier.c:5623 process_spin_lock() error: uninitialized symbol 'rec'.
vim +/rec +5623 kernel/bpf/verifier.c
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5588 static int process_spin_lock(struct bpf_verifier_env *env, int regno,
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5589 bool is_lock)
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5590 {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5591 struct bpf_reg_state *regs = cur_regs(env), *reg = ®s[regno];
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5592 struct bpf_verifier_state *cur = env->cur_state;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5593 bool is_const = tnum_is_const(reg->var_off);
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5594 u64 val = reg->var_off.value;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5595 struct bpf_map *map = NULL;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5596 struct btf_record *rec;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5597 struct btf *btf = NULL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5598
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5599 if (!is_const) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5600 verbose(env,
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5601 "R%d doesn't have constant offset. bpf_spin_lock has to be at the constant offset\n",
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5602 regno);
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5603 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5604 }
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5605 if (reg->type == PTR_TO_MAP_VALUE) {
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5606 map = reg->map_ptr;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5607 if (!map->btf) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5608 verbose(env,
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5609 "map '%s' has to have BTF in order to use bpf_spin_lock\n",
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5610 map->name);
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5611 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5612 }
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5613 rec = map->record;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5614 } else {
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5615 struct btf_struct_meta *meta;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5616
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5617 btf = reg->btf;
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5618 meta = btf_find_struct_meta(reg->btf, reg->btf_id);
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5619 if (meta)
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5620 rec = meta->record;
No else path.
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5621 }
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5622
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 @5623 if (!btf_record_has_field(rec, BPF_SPIN_LOCK)) {
^^^
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5624 verbose(env, "%s '%s' has no valid bpf_spin_lock\n", map ? "map" : "local",
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5625 map ? map->name : "kptr");
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5626 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5627 }
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5628 if (rec->spin_lock_off != val + reg->off) {
db559117828d24 Kumar Kartikeya Dwivedi 2022-11-04 5629 verbose(env, "off %lld doesn't point to 'struct bpf_spin_lock' that is at %d\n",
425ce908da14d5 Kumar Kartikeya Dwivedi 2022-11-12 5630 val + reg->off, rec->spin_lock_off);
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5631 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5632 }
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5633 if (is_lock) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5634 if (cur->active_spin_lock) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5635 verbose(env,
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5636 "Locking two bpf_spin_locks are not allowed\n");
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5637 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5638 }
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5639 cur->active_spin_lock = reg->id;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5640 } else {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5641 if (!cur->active_spin_lock) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5642 verbose(env, "bpf_spin_unlock without taking a lock\n");
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5643 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5644 }
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5645 if (cur->active_spin_lock != reg->id) {
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5646 verbose(env, "bpf_spin_unlock of different lock\n");
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5647 return -EINVAL;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5648 }
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5649 cur->active_spin_lock = 0;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5650 }
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5651 return 0;
d83525ca62cf8e Alexei Starovoitov 2019-01-31 5652 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-11-14 8:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 19:31 [PATCH bpf-next v6 00/26] Allocated objects, BPF linked lists Kumar Kartikeya Dwivedi
2022-11-11 19:31 ` [PATCH bpf-next v6 01/26] bpf: Remove local kptr references in documentation Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 02/26] bpf: Remove BPF_MAP_OFF_ARR_MAX Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 03/26] bpf: Fix copy_map_value, zero_map_value Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 04/26] bpf: Support bpf_list_head in map values Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 05/26] bpf: Rename RET_PTR_TO_ALLOC_MEM Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 06/26] bpf: Rename MEM_ALLOC to MEM_RINGBUF Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 07/26] bpf: Refactor btf_struct_access Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 08/26] bpf: Introduce allocated objects support Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 09/26] bpf: Recognize lock and list fields in allocated objects Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 10/26] bpf: Verify ownership relationships for user BTF types Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 11/26] bpf: Allow locking bpf_spin_lock in allocated objects Kumar Kartikeya Dwivedi
2022-11-14 8:25 ` Dan Carpenter [this message]
2022-11-14 9:11 ` Kumar Kartikeya Dwivedi
2022-11-14 9:38 ` Dan Carpenter
2022-11-11 19:32 ` [PATCH bpf-next v6 12/26] bpf: Allow locking bpf_spin_lock global variables Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 13/26] bpf: Allow locking bpf_spin_lock in inner map values Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 14/26] bpf: Rewrite kfunc argument handling Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 15/26] bpf: Drop kfunc bits from btf_check_func_arg_match Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 16/26] bpf: Support constant scalar arguments for kfuncs Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 17/26] bpf: Introduce bpf_obj_new Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 18/26] bpf: Introduce bpf_obj_drop Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 19/26] bpf: Permit NULL checking pointer with non-zero fixed offset Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 20/26] bpf: Introduce single ownership BPF linked list API Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 21/26] bpf: Add 'release on unlock' logic for bpf_list_push_{front,back} Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 22/26] selftests/bpf: Add __contains macro to bpf_experimental.h Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 23/26] selftests/bpf: Update spinlock selftest Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 24/26] selftests/bpf: Add failure test cases for spin lock pairing Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 25/26] selftests/bpf: Add BPF linked list API tests Kumar Kartikeya Dwivedi
2022-11-11 19:32 ` [PATCH bpf-next v6 26/26] selftests/bpf: Add BTF sanity tests Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211140520.Q5kvXPSL-lkp@intel.com \
--to=error27@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@meta.com \
--cc=delyank@meta.com \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox