Re: [xdp-hints] [PATCH bpf-next v2 8/8] selftests/bpf: Simple program to dump XDP RX metadata

Stanislav Fomichev
2022-11-23T19:55:52Z

On Wed, Nov 23, 2022 at 11:17 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 23 Nov 2022 10:29:23 -0800 Stanislav Fomichev wrote:
> > > return ch.rx_count ?: ch.combined_count;
> > >
> > > works though :)
> >
> > Perfect, will do the same :-) Thank you for running and testing!
>
> The correct value is ch.rx_count + ch.combined_count
>
> We've been over this many times, I thought it was coded up in libbpf
> but I don't see it now :S

Yeah, can't find it. Also doesn't exist on libxdp/libxsk. Will apply
your fix, thank you!