Re: [PATCH v3 2/2] bpf: makefiles: do not generate empty vmlinux.h

Quentin Monnet
2022-12-20T15:38:43Z

2022-12-18 06:35 UTC+0800 ~ Changbin Du <changbin.du@gmail.com>
> Remove the empty vmlinux.h if bpftool failed to dump btf info.
> The empty vmlinux.h can hide real error when reading output
> of make.
>
> This is done by adding .DELETE_ON_ERROR special target in related
> makefiles.
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
> tools/bpf/bpftool/Makefile | 3 +++
> tools/testing/selftests/bpf/Makefile | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> index 787b857d3fb5..313fd1b09189 100644
> --- a/tools/bpf/bpftool/Makefile
> +++ b/tools/bpf/bpftool/Makefile
> @@ -289,3 +289,6 @@ FORCE:
> .PHONY: all FORCE bootstrap clean install-bin install uninstall
> .PHONY: doc doc-clean doc-install doc-uninstall
> .DEFAULT_GOAL := all
> +
> +# Delete partially updated (corrupted) files on error
> +.DELETE_ON_ERROR:

Acked-by: Quentin Monnet <quentin@isovalent.com>

Thanks!